Remove leftover mentions of help_topics namespace in help module

There's 2 more places to update in documentation (probably) or keep it as is
I fixed second mention to look for examples in the help module's topics

core/modules/help/help.module:39:      $output .= '<p>' . t('Help topics provided by modules and themes are also part of the Help module. If the core Search module is enabled, these topics are searchable. For more information, see the <a href=":online">online documentation for Help Topics</a>.', [':online' => 'https://www.drupal.org/documentation/modules/help_topics']) . '</p>';
core/modules/help/help.module:49:      $output .= '<dd>' . t("Modules and themes can provide help topics as Twig-file-based plugins in a project sub-directory called <em>help_topics</em>; plugin meta-data is provided in YAML front matter within each Twig file. Plugin-based help topics provided by modules and themes will automatically be updated when a module or theme is updated. Use the plugins in <em>core/modules/help_topics/help_topics</em> as a guide when writing and formatting a help topic plugin for your theme or module.") . '</dd>';

the first link redirects to https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

better title

@Amber the link to https://www.drupal.org/documentation/modules/help_topics → is primary question of replacement

Seen this one laying around so thought I'd take a look.

Should the patches #2 and #3 be combined?

Yes, and question in #3 needs Amber

Alright, here's a patch that adds to the one in #3, updating the URL and link text to the Help Topic Standards docs page (without the redirect).

@Amber thank you! please add patch from #2 to final one

Thanks for the clarification, @andypost. This patch adds the patch from #2 (the changes to core/modules/help/tests/src/Kernel/HelpSearchPluginTest.php). Interdiff included.

Ok, I think this is ready for review!

The last submitted patch, 8: 3377604-8.patch, failed testing. View results →

I think it ready

I applied the patch and searched core for "\help_topics" outside of the help_topics module. Only references to test modules that have names beginning with that string are found.

$ grep -ri "\\\help_topics" core | grep -v modules/help_topics/ | grep help_topics
core/modules/help/tests/src/Functional/HelpTopicSearchTest.php:    // \Drupal\help_topics_test\Plugin\HelpSection\TestHelpSection.
core/modules/help/tests/src/Functional/HelpTopicsSyntaxTest.php:use Drupal\help_topics_twig_tester\HelpTestTwigNodeVisitor;
core/modules/help/tests/modules/help_topics_test/src/Plugin/HelpTopic/TestHelpTopicPlugin.php:namespace Drupal\help_topics_test\Plugin\HelpTopic;
core/modules/help/tests/modules/help_topics_test/src/Plugin/HelpSection/TestHelpSection.php:namespace Drupal\help_topics_test\Plugin\HelpSection;
core/modules/help/tests/modules/help_topics_test/src/Plugin/Deriver/TestHelpTopicDeriver.php:namespace Drupal\help_topics_test\Plugin\Deriver;
core/modules/help/tests/modules/help_topics_test/src/Plugin/Deriver/TestHelpTopicDeriver.php:      'class' => 'Drupal\\help_topics_test\\Plugin\\HelpTopic\\TestHelpTopicPlugin',
core/modules/help/tests/modules/help_topics_test/src/Controller/HelpTopicsTestController.php:namespace Drupal\help_topics_test\Controller;
core/modules/help/tests/modules/help_topics_test/help_topics_test.help_topics.yml:  class: 'Drupal\help_topics_test\Plugin\HelpTopic\TestHelpTopicPlugin'
core/modules/help/tests/modules/help_topics_test/help_topics_test.help_topics.yml:  deriver: 'Drupal\help_topics_test\Plugin\Deriver\TestHelpTopicDeriver'
core/modules/help/tests/modules/help_topics_test/help_topics_test.routing.yml:    _controller: '\Drupal\help_topics_test\Controller\HelpTopicsTestController::testPage'
core/modules/help/tests/modules/help_topics_twig_tester/help_topics_twig_tester.services.yml:    class: Drupal\help_topics_twig_tester\HelpTestTwigExtension
core/modules/help/tests/modules/help_topics_twig_tester/src/HelpTestTwigExtension.php:namespace Drupal\help_topics_twig_tester;
core/modules/help/tests/modules/help_topics_twig_tester/src/HelpTestTwigNodeVisitor.php:namespace Drupal\help_topics_twig_tester;

Thanks for the cleanup!

Automatically closed - issue fixed for 2 weeks with no activity.