- 🇫🇷France andypost
I think we can proceed here as it already happening 📌 Move help topics to actions module Fixed
- Status changed to Needs review
over 1 year ago 5:00am 1 March 2023 - Status changed to Needs work
over 1 year ago 5:15pm 3 March 2023 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Why do we need to remove this restriction? Or to turn the question around. Why should module A be able to provide a help topic for module B. I might be missing something but I'm not sure why we'd want that.
I would have expected this patch to be the following change
if ($provider !== $file_name_provider) { throw new DiscoveryException("$file file name should begin with '$provider'"); }
i.e. we remove the help topics special case.
- Status changed to Postponed
over 1 year ago 12:47am 4 March 2023 - 🇳🇿New Zealand quietone
The help_topics for Action are being moved because the module is being deprecated, it is not because of the work to make Help Topics stable. 🌱 Help Topics module roadmap: the path to beta and stable Fixed . In the Issue Summary for that issue it states that parent of this issue is not to be worked on until "all of the required issues above have been resolved, and all the questions answered". There are still 5 issues in that category listed on 3027054 that have not been resolved. I think this needs to wait until 📌 Finalize the merge of Help Topics into Help Fixed is active.
Therefore I am restoring the postponed status.
- 🇫🇷France andypost
It should remain postponed until topics are moved to help module, the move in 📌 Merge Help Topics classes into Help with BC layer Fixed
- Status changed to Needs work
over 1 year ago 8:24am 26 June 2023 - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @andypost opened merge request.
- last update
over 1 year ago 29,553 pass - Status changed to Needs review
over 1 year ago 10:41am 26 June 2023 - Status changed to RTBC
over 1 year ago 2:05pm 26 June 2023 - 🇺🇸United States smustgrave
Beautiful thing to see all those topics landing in their respective modules.
The placement of the files seem to fall in the correct modules to me.
- last update
over 1 year ago 29,561 pass - last update
over 1 year ago 29,565 pass - last update
over 1 year ago 29,570 pass - Status changed to Needs work
over 1 year ago 7:45am 4 July 2023 - 🇳🇿New Zealand quietone
I checked the file renaming and did not find any errors. I would like to know why test coverage is being removed.
- Status changed to Needs review
over 1 year ago 11:36am 4 July 2023 - 🇫🇷France andypost
The test case
testDiscoveryExceptionProviderMismatch
was removed because it was testing that topics are living in help module (help topics previously) and this why commit message said this barrier is removed - 🇫🇷France andypost
- Status changed to RTBC
over 1 year ago 1:42pm 5 July 2023 - last update
over 1 year ago 29,800 pass - 🇳🇿New Zealand quietone
@andypost, thanks. I reread the test more carefully this time. I think this is ready to commit but it is too late for me to do so now.
- last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,806 pass - last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,814 pass - last update
over 1 year ago 29,814 pass - last update
over 1 year ago 29,818 pass, 1 fail - last update
over 1 year ago 29,841 pass - last update
over 1 year ago 29,877 pass - last update
over 1 year ago 29,875 pass, 1 fail - last update
over 1 year ago 29,877 pass -
larowlan →
committed 58233075 on 11.x
Issue #3025577 by andypost, Abhisheksingh27, jhodgdon, alexpott,...
-
larowlan →
committed 58233075 on 11.x
- Status changed to Fixed
over 1 year ago 10:03am 24 July 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Applied on top of 📌 Move help topics to book module Fixed and pushed to 11.x - Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.