- π«π·France andypost
I think it's time to make active π Finalize the merge of Help Topics into Help Fixed and π Move help topics to core or the correct modules Fixed
as only 3 issues left in π± [META] Fix up topics to use new help_route_link function Fixed
- π«π·France andypost
Updated IS
- Closed as useless complexity β¨ Do we need hierarchy/order for help topics? Active
- Now unrelated as topics using twig β¨ Automatically map !translate YAML tag to TranslatableMarkup Needs work
- Frontend does not need π Create TemplateDiscovery for plugin managers to use Needs review all that timeThe only actionable issue left is [3041924]
- π«π·France andypost
As last blocker fixed it needs new issue to consider and set module stable
Remaining minors
- points in π Fix up minor copy problems in help topics Fixed are only related to future renames in UI
- extra test addition π Add tests to enforce correct use of help_topic_link and help_route_link functions Fixed is follow-up to π Make a way for help topics to generate links only if they work and are accessible Fixed - π«π·France andypost
I set active π Finalize the merge of Help Topics into Help Fixed because we can't deprecate hook_help before help_topics is stable and replacement for the help block is ready
So I filed π Mark Help topics as a stable module Closed: won't fix
- π«π·France andypost
Updated is
- not a part of roadmap but great follow-up π± Deprecate hook_help() and combine with Topics Active
- ordered issues as- first we need to merge π Merge Help Topics classes into Help with BC layer Fixed
- then move topics π Move help topics to core or the correct modules Fixed
- clean-up tests - π«π·France andypost
New issue happened π Standardize how external links are wrapped with Twig trans/endtrans tags in help topics Active as consequence of π Fix up minor copy problems in help topics Fixed
- π«π·France andypost
Help topics are merged into help, now polishing
next target is π Move help topics to core or the correct modules Fixed
- π«π·France andypost
Added β¨ Add new permission for accessing help pages Fixed to IS as it will have collision with π Add help_search plugin to the base admin theme test Fixed
- π«π·France andypost
I find π Move testing of help topic rendering into child of GenericModuleTestBase Active optional from 2 remaining issues from summary, no reason to slowdown tests for testing install of shipped topics within each module
So now it needs to announce deprecation of help_topics module and "long live help topics in help" at the same time
- π«π·France andypost
So left overs are
- π Fix up minor copy problems in help topics Fixed
- π Add help_search plugin to the base admin theme test Fixed - Status changed to RTBC
over 1 year ago 12:44pm 20 August 2023 - π«π·France andypost
I bet we can mark the issue fixed now, 4 years!
The remaining issue from summary should be postponed on deprecating hook help π Move testing of help topic rendering into child of GenericModuleTestBase Active
Also there's π Merge Help Topics classes into Help with BC layer Fixed which is RTBC and waiting for release manager to set it fixed.
So I bet we can set this issue fixed as well and continue with remaining issues in help module's queue
- π«π·France andypost
Deprecation of hook help moved to plan to consider BC π± Deprecate hook_help() and combine with Topics Active
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
Updated the IS. Per @andypost in #99 (and I, as co-maintainer, concur), moving some items in the IS that were in the section "Needs discussion" to "Not part of the roadmap".
- Moved β¨ Do we need hierarchy/order for help topics? Active to the section "Not part of the roadmap".
- Moved "
- #3064854: Allow Twig templates to use front matter for metadata support β , and if that is done, #3085972: Replace Drupal\help_topics\FrontMatter with Drupal\Component\Utility\FrontMatter β
- Moved π Move testing of help topic rendering into child of GenericModuleTestBase Active to "Not part of the roadmap" as it's not a part of this roadmap, but a child of π± Deprecate hook_help() and combine with Topics Active (per #111
" to the section "Not part of the roadmap"
Hopefully the IS now clearly reflects that there are no action items remaining.
- Status changed to Fixed
over 1 year ago 10:53am 17 October 2023 - π«π·France andypost
The last child been marked as fixed π Merge Help Topics classes into Help with BC layer Fixed
Consider maintenance of help module now going by the help module core's issue queue
Automatically closed - issue fixed for 2 weeks with no activity.