- Issue created by @andypost
- Status changed to Needs work
over 1 year ago 3:48pm 21 April 2023 - last update
over 1 year ago 29,299 pass, 1 fail - last update
over 1 year ago 29,299 pass, 1 fail - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,300 pass - πΊπΈUnited States Amber Himes Matz Portland, OR USA
Updated issue summary and title for clarity.
- π¬π§United Kingdom catch
π Finalize the merge of Help Topics into Help Fixed suggests that rather than actually mark help topics as stable, we would instead move the code from help topics into the existing help module. With that the existing help_topics module would need to be marked obsolete and eventually removed from core and we just have 'help' with both help topics and hook_help(), and then eventually deprecate hook_help().
I think we definitely don't want two help modules in core, so we either need to merge help topics into help, or change the plan to make help topics the only module in core by deprecating and removing help - however doing so would mean two stable help modules in core until that happens, and 'help' still seems like a good namespace to keep in core, so for me the original plan is better.
So... I think we should mark this as a duplicate of π Finalize the merge of Help Topics into Help Fixed and focus efforts over there instead, but leaving needs work for discussion.
- π«π·France andypost
My intent to make it stable is just to find better wording for class-comments, OTOH on the move we probably should spread topics to their modules (it was separate issue) because help (as stable) can't show topics from help_topics (experimental)
So this issue is an attempt to solve chicken-egg loop
+++ b/core/modules/help_topics/src/Controller/HelpTopicPluginController.php @@ -14,9 +14,7 @@ * @internal - * Help Topic is currently experimental and should only be leveraged by - * experimental modules and development releases of contributed modules. - * See https://www.drupal.org/core/experimental for more information.
This comment is all over classes, when moving to help module no BC required but wording needs some better wording
- π¬π§United Kingdom catch
If we move the help topics API to help module, that would count as stable, then the individual help topics can all move to their respective modules. Or we could just decide to do both at the same time if there's a proper chicken and egg situation.
Although I think it would be possible for help topics module to continue providing the topics for other core modules while that's happening (especially if we get it all done within 8.2's development cycle for example). - π«π·France andypost
Thank you @catch! Then next actionable issue is π Merge Help Topics classes into Help with BC layer Fixed
I still hope it will be just a move of classes with BC phantoms in help topics, then update hook to disable help-topics
I will start in this weekend
- Status changed to Closed: won't fix
over 1 year ago 2:33pm 27 April 2023