Move testing of help topic rendering into child of GenericModuleTestBase

Gonna check it as help topics are merged to help module

There's still TODO in HelpTopicsSyntaxTest so the issue still actional

summary outdated, still makes sense to check supplied topics in common test which installs every module

There's \Drupal\Tests\system\Functional\Module\InstallUninstallTest::assertHelpwhich is checking required hook_help() implementation for core modules.

I think we should leave the test as is because
- it's purpose to do syntax checks of topics, which is unrelated to system module
- the test already self explaining but InstallUninstallTest doc-block is totally unclear and doing more then decumented

Install/uninstall core module and confirm table creation/deletion.

For the IS update.

Change you made looks simple enough.

Trying to run tests locally

Testing Drupal\Tests\help\Functional\HelpTopicsSyntaxTest
Test 'Drupal\Tests\help\Functional\HelpTopicsSyntaxTest::testHelpTopics' started
Test 'Drupal\Tests\help\Functional\HelpTopicsSyntaxTest::testHelpTopics' ended


Time: 06:11.269, Memory: 4.00 MB

OK (1 test, 13382 assertions)
...
real	6m12,258s
user	0m0,040s
sys	0m0,022s

Second one can't complete (fails installing mysql as I'm using sqlite)

Testing Drupal\Tests\system\Functional\Module\InstallUninstallTest
Test 'Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall' started
Test 'Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall' ended


Time: 12:53.326, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected.

...
real	12m55,073s
user	0m0,038s
sys	0m0,045s

Don't mind marking this for you.

I looked at the patch and see that this is not moving a test. Setting back to needs work for a title update.

On the other hand the comment being removed states

so that it will test with only one module at a time installed and not duplicate the effort

As I read that it means that the intention was to test each module without other modules installed.

Looking at the history I find support of that interpretation.

The @todo comment was added in #3066512-15: Add checks for syntax and display of help topic Twig template files → . The following comment in the issue states,

c) Write a test that would install all the non-hidden and non-test modules at once, and verify all the help topics can be rendered. This would not be as rigorous as testing with the modules individually installed, because it might mask problems in routes not being defined, but it would be better than nothing.

It does seem that this is to add more testing. Is there a reason not to add this level of testing?

Proper parent is 🌱 Deprecate hook_help() and combine with Topics Active

when we consider to require help topics instead of hook_help() this action becomes doable

There's GenericModuleTestBase now