- π«π·France andypost
Added π UI: Rename 'menu items' to 'menu links' for more consistency Needs work for 7)
Making active as only one conversion left π Update sentence-embedded internal links in content_moderation, core.content_structure, search.overview help topics to use help_route_link function Fixed
- π«π·France andypost
For 1 filed π Fix wording aroud 403/404 in help topic Fixed
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
- Opened π Update topic contact.setting_default to use route instead of "/contact" Fixed and updated IS
- Opened π Create or update help topics that cover CKEditor 5's module overview text in hook_help() Active and updated ISIβm going through the issue summary and creating child issues. The current issue summary is confusing because at a glance, it links to a bunch of fixed issues. But the fixed issues were not related to the updates needed to help topics, but rather changes to Drupal core that should be reflected in respective help topics.
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
From this issue summary, I added the following item:
On #3150364: Add a description for the language toolbar button to the CKEditor help page β they also made a list of accessibility features and a section about making accessible text. I'm not sure we covered that well in our topic on Accessibility, so we should check. See this screenshot of the output of one of the patches:
to π Create or update help topics that cover CKEditor 5's module overview text in hook_help() Active
See also this comment: https://www.drupal.org/project/drupal/issues/3358585#comment-15116862 π Create or update help topics that cover CKEditor 5's module overview text in hook_help() Active
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
I've updated the issue summary to denote where items have been fixed, outdated (no longer an issue), "won't fix", moved to separate issues, or in-scope ("PATCH") for this issue.
Also changed this issue back to "Task" as I have a patch/MR almost ready to fix the remaining in-scope issues here.
- last update
over 1 year ago 29,531 pass - @amber-himes-matz opened merge request.
- Status changed to Needs review
over 1 year ago 8:30pm 22 June 2023 - πΊπΈUnited States Amber Himes Matz Portland, OR USA
I've submitted a merge request which addressed all remaining "PATCH" items in the issue summary. These are mostly nits and standardizing on the User Guide links in the Additional resources.
I've opened separate issues where there a content update to a topic is needed.
This will be ready for review after the tests run (and hopefully pass).
- Status changed to Needs work
over 1 year ago 9:15pm 22 June 2023 - πΊπΈUnited States Amber Himes Matz Portland, OR USA
After discussing with @andypost in Slack, I'm going to "undo" changes in this MR where I moved the Twig
{% trans %}{% endtrans %}
wrapping (in Additional resources external links). I opened a new issue to discuss this π Standardize how external links are wrapped with Twig trans/endtrans tags in help topics Active . - last update
over 1 year ago 29,531 pass - Status changed to Needs review
over 1 year ago 9:28pm 22 June 2023 - πΊπΈUnited States Amber Himes Matz Portland, OR USA
I've pushed new commits that "undo" changes to Twig trans tag wrapping and resolved the thread discussing this. Ready for review (assuming tests pass).
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
Updated issue summary regarding opening π Standardize how external links are wrapped with Twig trans/endtrans tags in help topics Active as separate issue and not addressed in this issue.
- Status changed to RTBC
over 1 year ago 11:51pm 22 June 2023 - π«π·France andypost
Thank you!
First I did not get why Drupal User Guide (all caps) but then grepped and it's separate terms, I bet commiter will check if I miss some grammar
- last update
over 1 year ago 29,553 pass - last update
over 1 year ago 29,559 pass - last update
over 1 year ago 29,563 pass - last update
over 1 year ago 29,571 pass 25:36 23:02 Running- last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,806 pass - last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,822 pass - last update
over 1 year ago 29,837 pass - last update
over 1 year ago 29,878 pass - last update
over 1 year ago 29,877 pass - π«π·France andypost
Rebased after π Move help topics to core or the correct modules Fixed
- last update
over 1 year ago 29,877 pass - πΊπΈUnited States Amber Himes Matz Portland, OR USA
When I checked the MR just now, it said it was still blocked even after @andypost rebased earlier today, so I hit the rebase button again, and now it looks "able to merge" again.
- last update
over 1 year ago 29,882 pass - last update
over 1 year ago 29,886 pass - last update
over 1 year ago 29,908 pass - last update
over 1 year ago 29,946 pass - last update
over 1 year ago 29,946 pass - Status changed to Needs work
over 1 year ago 2:46am 4 August 2023 - π³πΏNew Zealand quietone
Looking at the issue summary I see a wall of things to fix. I do not see a proposed resolution for this issue or remaining tasks.
Can someone update the Issue Summary so it is clear what this issue is fixing?
- Status changed to RTBC
over 1 year ago 4:47am 4 August 2023 - π«π·France andypost
Issue summary is valid, it was "just updated" in #50 marking 10-11, 13-15 actionable - marked as
PATCH
I see no reason to remove the history of all aggregated bugs which was collected last 3 years awaiting for final merge and spawning new issue from the IS
All things are marked as MOVED still makes sense and must remain linked as well
- π³πΏNew Zealand quietone
I should be clear that I have not asked for history to be removed (now would I). This just needs something to help the reviewer easily find what is being fixed in this issue. Also, the first paragraph states in bold that this issue is postponed, that alone got me wondering about the state of the Issue Summary.
I read through the comments and see in #38 that xjm was concerned about the scope here. Now that I understand what items in that long are being fixed here I read those points. I too am concerned about the scope here and that separate problems are being fixed in one issue. However, I do not know the background here so will leave the current status.
Finally, I started adding credit.
- πΊπΈUnited States Amber Himes Matz Portland, OR USA
Thank you @quietone for pointing out that this IS is a bit of a hard-to-understand mess. And to @xjm for pointing out the scoping problem. I have updated the title and issue summary as follows:
- Removed statement about it being postponed, because it is not.
- Updated title to "Fix up minor copy problems in help topics" since this issue is only focused on copy edits, not content or code errors (scope).
- Updated issue summary. Moved the original summary down to "Original issue summary section". Organized the IS into template with clear action items and scope, and indicated what has been done.
- Added referenced issues
- Added Release notes snippet
Also, just to add additional context and clarification, this issue historically was a sort of meta issue to collect problems. Problems were fixed in other issues or new issues created. This issue is now scoped to minor copy edits related to word usage and consistent link text.
I hope this update makes it easier to review and commit. But feedback is always welcome on how it could be further clarified if clarification is required. Forgive us if we are a bit strained as getting help topics stable has been a long long road.
- last update
over 1 year ago 29,953 pass - π³πΏNew Zealand quietone
@Amber Himes Matz, thanks! That is really helpful. That is what I was looking for in the Issue Summary. I am pleased you understood what I meant.
- last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,958 pass 25:35 24:27 Running- last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 30,044 pass - Status changed to Fixed
over 1 year ago 9:58pm 18 August 2023 - π¬π§United Kingdom longwave UK
I read through the changes with
git diff --color-words
and they all make sense to me. Scoping these issues is always tricky but this one looks to have covered a good set of copy edits and I don't think it is worth nitpicking or rescoping, we should just commit these fixes and solve any remaining copy problems in other followups.Committed 83fe6aa and pushed to 11.x. Thanks!
-
longwave β
committed 83fe6aa3 on 11.x
Issue #3121340 by Amber Himes Matz, andypost, jhodgdon, quietone, xjm:...
-
longwave β
committed 83fe6aa3 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.