Update sentence-embedded internal links in content_moderation, core.content_structure, search.overview help topics to use help_route_link function

I'm sure it already took a review in 🌱 [META] Fix up topics to use new help_route_link function Fixed

But there was a changes so Gabor's approaval is needed, there's 2 more issues like that left to unblock help topics

Translatability-wise I don't see problems here looking at the patch. The menu item labels are used for the link labels and they are well disconnected from the sentences (as much as feasible) to allow for them to stand alone without being super-awkard. While allowing the permission checking features to work that the update is intended to support I believe. The resulting templates don't look pretty but that seems to be what it takes.

Here's how it looks and question of translation of the {{ whatever_link }} now solved by rewording

content_moderation.changing_states

search.overview

The last submitted patch, 15: 3307695-15.patch, failed testing. View results →

Unrelated

The last submitted patch, 15: 3307695-15.patch, failed testing. View results →

I triaged this and all comments have been addressed and there is signoff by a subsystem maintainer and testing with some screenshots. I also applied the patch, read it and checked that links. I found everything in order. I have updated credit.

We are in a freeze right now, so need to wait a few days.

Committed 8382926 and pushed to 10.1.x.

Thanks!

Thank you! it was the last blocker)

Automatically closed - issue fixed for 2 weeks with no activity.