Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()

Some of PHPUnit Functional Javascript tests and Nightwatch tests are failed.
Need to resolve failed tests.

is there an associated eslint rule to enforce this?

tests are green, changes looks good

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@nod_ No, I think no rule is found in ESLint plugins for vanilla JavaScript at this point.
"typescript-eslint" plugin has ESLint rule but this rule is for TypeScript.

Rebased with the latest changes in 11.x. Please review.

@sakthi_dev After commit id 135e3ba1 original script size is changed, so need to recalculate script size.

All tests are passed. Please review.

MR has conflict because of testing file changing at commit 05e4d1a8. Need to resolve this conflict.

Merge test file changing at commit 05e4d1a8 to the MR and all tests are passed.
Please review.

Left some comments on the MR.

Feedback appears to be addressed

nod_ → closed merge request !7411

Committed and pushed f5cc65456a to 11.x and cc355625ad to 11.0.x and 05b6144bd0 to 10.4.x and 270f95ac48 to 10.3.x. Thanks!

Can't tell but this one may be causing random failures on 11.x

Automatically closed - issue fixed for 2 weeks with no activity.