- Issue created by @longwave
- Status changed to Needs work
8 months ago 10:53pm 13 March 2024 - 🇬🇧United Kingdom longwave UK
The MR will fail for the uses in core that haven't been removed, we should explicitly add these (for now) instead of the wildcards.
- Status changed to Needs review
8 months ago 11:17pm 13 March 2024 - 🇬🇧United Kingdom longwave UK
The outcome here will also determine what we do with
ClassResolver::getInstanceFromDefinition()
:if ($instance instanceof ContainerAwareInterface) { $instance->setContainer($this->container); }
If we decide that ContainerAware should go away in Drupal 11 I think we should trigger a deprecation from there to further notify existing users?
- Status changed to Needs work
8 months ago 1:17pm 14 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇬🇧United Kingdom longwave UK
We can safely remove the ResetInterface skip here as that has already been resolved in 11.x (although this means we probably need two branches here as we will have to apply these changes to 10.3.x as well).
- 🇬🇧United Kingdom longwave UK
Given that Symfony is no longer supporting this interface our choice is to remove it entirely or clone it and implement it ourselves. There are some uses in contrib according to http://grep.xnddx.ru/search?text=ContainerAwareInterface but on inspection all sample cases look like they should be able to use dependency injection instead.
Therefore I think we should also deprecate that part of ClassResolver here, updated the IS and added a sample deprecation to core to see what breaks.
- Status changed to Needs review
8 months ago 10:51pm 15 March 2024 - 🇬🇧United Kingdom longwave UK
Added a change record and deprecation and adjusted the existing test coverage.
- Status changed to Needs work
8 months ago 11:29pm 15 March 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to RTBC
8 months ago 6:20am 16 March 2024 - 🇳🇱Netherlands spokje
Rebased to prove that review-bot was wrong, which it was.
Also RTBCed. - 🇬🇧United Kingdom alexpott 🇪🇺🌍
-
alexpott →
committed 96664ce8 on 10.3.x
Issue #3427741 by longwave, sakthi_dev, Spokje: Notify downstream users...
-
alexpott →
committed 96664ce8 on 10.3.x
- Status changed to Fixed
8 months ago 11:10am 17 March 2024 -
alexpott →
committed ab80fb20 on 11.x
Issue #3427741 by longwave, sakthi_dev, Spokje: Notify downstream users...
-
alexpott →
committed ab80fb20 on 11.x
-
alexpott →
committed aafa1554 on 10.3.x
Issue #3427741 follow-up: Notify downstream users that ContainerAware is...
-
alexpott →
committed aafa1554 on 10.3.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I had to add a follow-up commit on 10.3.x due to the deprecation being triggered by our tests - see https://git.drupalcode.org/project/drupal/-/commit/aafa15549cd89625ef6ce...
Automatically closed - issue fixed for 2 weeks with no activity.