- Issue created by @coaston
- Status changed to Needs review
about 2 years ago 10:19am 26 April 2023 - ๐ธ๐ฐSlovakia coaston
Fix :
replace
/css/components/dialog.css .ui-dialog .ui-icon.ui-icon-closethick { margin-top: -8px; - background: url(../../../../misc/icons/ffffff/ex.svg) 0 0 no-repeat; + background: url(../../images/icons/ffffff/ex.svg) 0 0 no-repeat;
Please review and create patch. Also reopen 3304752 โ as it was not pushed to latest release.
- ๐ฎ๐ณIndia santosh_verma Faridabad
#coaston i tested it with the 2 approaches
1. Fresh setup of D 10.1.x and installed the theme Seven via Git clone
=> icon path is changed(background: url(../../images/icons/ffffff/ex.svg) 0 0 no-repeat;)
and also icons copied into seven theme from coreResult- the close icon appearing,
2. Fresh setup of D 10.1.x and installed the theme Seven via composer
=> the image path is same as mention above (background: url(../../../../misc/icons/ffffff/ex.svg) 0 0 no-repeat;) and also there is not any folder in the cion folder named(ffffff)Result- the close icon missing
- Status changed to Closed: duplicate
about 2 years ago 5:08pm 9 May 2023 - ๐ซ๐ฎFinland lauriii Finland
Closing as a duplicate of ๐ Icons are missing Fixed .
- ๐ธ๐ฐSlovakia coaston
Hi Laurii, not sure if you red my notes, but it is not duplicated ticket, At least it is different path.
Hope it is fixed now.
- Status changed to Active
about 2 years ago 6:27am 10 May 2023 - ๐ซ๐ฎFinland lauriii Finland
Sorry, I was trying to clean up the queue too quickly. Re-opening ๐
- ๐ธ๐ฐSlovakia coaston
Hi Lauriii,
Can you be so kind and create patch as described in #4 ?
- First commit to issue fork.
- Status changed to Needs review
about 2 years ago 7:12am 10 May 2023 - ๐ฎ๐ณIndia sakthi_dev
Hi @coaston made a commit based on #4 comment.
- ๐ฉ๐ฐDenmark ressa Copenhagen
If I install the Seven theme with Composer, I get the latest release 1.0.0 and the icon is there. Maybe try to update to that version @coaston?
composer require drupal/seven [...] - Installing drupal/seven (1.0.0): Extracting archive
- ๐ณ๐ฟNew Zealand code_brown
Just adding that I was also on the 1.0.0-alpha1 release, noticed icon paths were incorrect, updated to the 1.0.0 release and they are now fixed. Happy days.
Hi,
Verified the bug on Drupal 10.2.0 version. But I am able to see X button without applying the patch.Test steps -
- Install Seven theme
- Go to Views
- Add views
- Add fields
- Verify X buttonKeeping it in review for further reviews.
Attached Screenshot for reference.- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
avpaderno โ made their first commit to this issueโs fork.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
It seems the merge request does not contain changes.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The changes in ๐ Icons are missing Fixed has been committed in the 1.0.x branch, and then the release 1.0.0 has been created.
To see all the icons, it is necessary to update to that release.