Icons are missing

Created on 18 April 2023, over 1 year ago
Updated 26 March 2024, 8 months ago

Problem/Motivation

Reopening this issue https://www.drupal.org/project/seven/issues/3304752 🐛 Icons are missing Fixed as it is not possible to reopen it.

The patch has not been released in the current version, hence it was closed by a mistake I believe. However after I have applied the patch I can still see following issues:

page not found /misc/icons/ffffff/ex.svg

Example : go to views, add any field and you can see that X cancel button of modal window is missing icon - above error in logs.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇸🇰Slovakia coaston

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @coaston
  • Status changed to Needs review over 1 year ago
  • 🇸🇰Slovakia coaston

    Fix :

    replace

    /css/components/dialog.css
    
    .ui-dialog .ui-icon.ui-icon-closethick {
      margin-top: -8px;
    -  background: url(../../../../misc/icons/ffffff/ex.svg) 0 0 no-repeat;
    +  background: url(../../images/icons/ffffff/ex.svg) 0 0 no-repeat;
    

    Please review and create patch. Also reopen 3304752 as it was not pushed to latest release.

  • 🇮🇳India Santosh_Verma

    #coaston i tested it with the 2 approaches

    1. Fresh setup of D 10.1.x and installed the theme Seven via Git clone
    => icon path is changed(background: url(../../images/icons/ffffff/ex.svg) 0 0 no-repeat;)
    and also icons copied into seven theme from core

    Result- the close icon appearing,

    2. Fresh setup of D 10.1.x and installed the theme Seven via composer
    => the image path is same as mention above (background: url(../../../../misc/icons/ffffff/ex.svg) 0 0 no-repeat;) and also there is not any folder in the cion folder named(ffffff)

    Result- the close icon missing

  • Status changed to Closed: duplicate over 1 year ago
  • 🇫🇮Finland lauriii Finland

    Closing as a duplicate of 🐛 Icons are missing Fixed .

  • 🇸🇰Slovakia coaston

    Hi Laurii, not sure if you red my notes, but it is not duplicated ticket, At least it is different path.

    Hope it is fixed now.

  • Status changed to Active over 1 year ago
  • 🇫🇮Finland lauriii Finland

    Sorry, I was trying to clean up the queue too quickly. Re-opening 👍

  • 🇸🇰Slovakia coaston

    Hi Lauriii,

    Can you be so kind and create patch as described in #4 ?

  • First commit to issue fork.
  • @sakthi_dev opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India sakthi_dev

    Hi @coaston made a commit based on #4 comment.

  • 🇩🇰Denmark ressa Copenhagen

    If I install the Seven theme with Composer, I get the latest release 1.0.0 and the icon is there. Maybe try to update to that version @coaston?

    composer require drupal/seven
    [...]
      - Installing drupal/seven (1.0.0): Extracting archive
    
  • 🇳🇿New Zealand code_brown

    Just adding that I was also on the 1.0.0-alpha1 release, noticed icon paths were incorrect, updated to the 1.0.0 release and they are now fixed. Happy days.

  • Hi,
    Verified the bug on Drupal 10.2.0 version. But I am able to see X button without applying the patch.

    Test steps -
    - Install Seven theme
    - Go to Views
    - Add views
    - Add fields
    - Verify X button

    Keeping it in review for further reviews.
    Attached Screenshot for reference.

Production build 0.71.5 2024