- Issue created by @rajeshreeputra
- 🇮🇳India rajeshreeputra Pune
Added few other issue that are currently in review state.
- 🇮🇳India rajeshreeputra Pune
Will focus on these 12 issue with current plan.
- 🇮🇳India rajeshreeputra Pune
📌 Fix deprecation warning. Active is merged!
- 🇮🇳India rajeshreeputra Pune
📌 Update README.md as per README.md format Needs review and 📌 Fix eslint test Active now merged, added 📌 Modernize the Drush commands Needs review as ready for review.
- 🇮🇳India rajeshreeputra Pune
- 🇯🇵Japan ptmkenny
Why is the list an ordered list? Are the issues dependent on one another? (I'm guessing no because some of the later issues have already been committed.)
Also, if this is a list of issues to address that's fine, but if this is for the release notes, mglaman has created an excellent release notes generator that can make this kind of list automatically.
The big question is should Key drop support for Drupal 8 and/or 9. Historically, Key (and Encrypt) has tried to maintain compatibility even pass Drupal core's support window.
- 🇯🇵Japan ptmkenny
If support for Drupal 8/9 is dropped, I think we should not just "require Drupal 10" but actually take the opportunity to modernize the code and use some of the new features of Drupal 10.
For example, these two issues already exist:
✨ Modernize services: Add autowiring aliases, use autoconfigure, constructors, etc Active
📌 Add attributes to plugins in addition to annotations Postponed
Committing these two would require 10.2+.
- 🇮🇳India rajeshreeputra Pune
Hello @ptmkenny,
Why is the list an ordered list? Are the issues dependent on one another? (I'm guessing no because some of the later issues have already been committed.)
The issues are not dependent on one another, and it is not necessary for the list to be ordered. We can remove the serial number column from the table.
The big question is should Key drop support for Drupal 8 and/or 9.
The decision to drop this support has already been considered, and it will be removed in the next major version. For more details, please refer to the discussions in the key channel here.
If support for Drupal 8/9 is dropped, I think we should not just "require Drupal 10" but actually take the opportunity to modernize the code and use some of the new features of Drupal 10.
I agree that we should not only require Drupal 10 but also take the opportunity to modernize the code and utilize some of the new features available in Drupal 10. This will be taken into account as part of the next major release, but I will defer to @rlhawk regarding the decision to drop support for Drupal 8 and/or 9 in the 1.x or 2.x.
- 🇯🇵Japan ptmkenny
@rajeshreeputra Thanks for the detailed explanation. I didn't know about the Slack channel and added some comments there. Since Slack isn't searchable from the web, I think it would be good to cut-and-paste any important conversation threads here.
- 🇮🇳India rajeshreeputra Pune
Removed 📌 Modernize the Drush commands Needs review from list as it depends on 📌 Remove support for Drupal < 9.1 Needs review .
- 🇮🇳India rajeshreeputra Pune
Removed #3483550 from list as it depends on #3306506 & #3524922