Account created on 31 March 2001, almost 24 years ago
#

Merge Requests

Recent comments

🇳🇱Netherlands gaele

Patch #2 fixes Facets 2, patch #6 fixes Facets 3. I'm not sure what the purpose of #7 is.

🇳🇱Netherlands gaele

Patch does not apply to 10.3.

🇳🇱Netherlands gaele

Well this RangeConditionTrait is not really a trait, as it only works for either total amount (#35) or total quantity (#37).

🇳🇱Netherlands gaele

Changing back to number.

🇳🇱Netherlands gaele

RangeConditionTrait is used for both OrderTotalPrice and OrderItemQuantity. In OrderTotalPrice min_value and max_value are Prices. In OrderItemQuantity min_value and max_value are numbers.

In #33 RangeConditionTrait was changed from using numbers to using Prices, resulting in OrderItemQuantity no longer working correctly.

🇳🇱Netherlands gaele

@albertosilva confirmed. I tried 8.x-1.20 and this is fixed. Thanks.

🇳🇱Netherlands gaele

What is left to do for a beta release of this module? Is there a roadmap?

🇳🇱Netherlands gaele

Better, but this still doesn't work for Search Api with offset dates.

🇳🇱Netherlands gaele

Adjusted patch, but:

undefined method addWhereExpression()

🇳🇱Netherlands gaele
  • Patch does not apply to 2.x
  • DatePopupSearchApi is not yet fixed
🇳🇱Netherlands gaele

I tried patch #9. It works, mostly. When I click Advanced I get this message, once:
Uncaught CKEditorError: collection-add-item-already-exists
The UI seems to work correctly, though.

🇳🇱Netherlands gaele

If I try patch #40 with 2.0.6 the filters work correctly but no longer use Ajax, i.e. the whole page is refreshed.

🇳🇱Netherlands gaele

The original CKEditor 5 plugin doesn't work with Drupal, so I'm not sure how to reproduce the error with that version.

Differences between the original and custom plugin: https://github.com/bvedad/ckeditor5-anchor/compare/master...northernco:c...
It seems the only meaningful differences are in anchorediting.js and utils.js.

🇳🇱Netherlands gaele

The behaviour when editing empty anchors is messy.

The easiest way to delete an empty anchor seems to be to double click the chain icon and then hit delete. However when I click anywhere on the empty anchor I expect the anchor edit pop-up to appear, just like when the anchor is not empty. Instead nothing happens. If I then click the anchor button, a pop-up to add a new anchor appears. If I cancel that, the anchor edit pop-up does appear, but CKeditor reports an error and stops working completely.

🇳🇱Netherlands gaele

Addition for multisite installation in a subdirectory:
https://samwaters.net/nginx-drupal-9-multisite-and-path-based-urls/

In short:

  location / {
    try_files $uri /index.php?$query_string;
  }

  #location /site1/ {
  #   try_files $uri /site1/index.php?$query_string;
  #}

  #location /site2/ {
  #   try_files $uri /site2/index.php?$query_string;
  #}
Production build 0.71.5 2024