- 🇫🇷France duaelfr Montpellier, France
I use "embed" views display type to put my views in some paragraphs.
This patch solves the issue of Ajax facets URL being badly generated.
I was trying to solve this by adding a bunch of code inFacetsUrlGenerator
but this solution is more effective and clean.Thanks a lot!
- First commit to issue fork.
- last update
over 1 year ago 424 pass, 2 fail - First commit to issue fork.
- last update
over 1 year ago 407 pass, 7 fail - last update
over 1 year ago 407 pass, 7 fail - 🇺🇸United States tlwatson
This patch does get the page working again, but I still get some trailing cruft in the URL that sticks around via the "q" parameter. This stacks if, say, I click on a couple facets to get the q parameter, press the reset/clear button on the Facets Summary or un-check all the selections (at which point we see the "q" parameter is still there), then start making new selections.
- 🇺🇦Ukraine andriic
@TLWatson issue with q param fixed here #3031544 🐛 Ajax facet adds q and _wrapper_format to the browser URL Needs review
- 🇺🇸United States Lanny Heidbreder
The attached patch is my attempt at another approach. When you select a facet, `facets-views-ajax.js` makes two AJAX requests: one for the view, and one for the facets in particular. The Views one returns the bad URLs, the Facets one returns correct URLs. The Views one is initiated first, but if it finishes last, you're stuck with the broken URLs. The patch ensures that the Facets AJAX call executes after the Views one is completely finished.
- 🇺🇸United States emptyvoid
Manually applied patches and rerolled the patch using Facets 2.0 to Drupal 10.2.4
- 🇺🇸United States emptyvoid
Doh, attaching patch based on the scope of the facets module instead of the root of my project.
- 🇺🇸United States emptyvoid
(facepalm)
I was missing the root /Apply this patch at the root of the facets module.
- Status changed to Needs review
8 months ago 10:59am 25 March 2024 - Status changed to RTBC
6 months ago 9:41am 6 June 2024 - 🇬🇧United Kingdom very_random_man
The patch in #19 is working well for me. Thanks!
- 🇮🇳India gajanannehul
#18 not working with views Ajax pagination and facet summary
- Status changed to Needs work
5 months ago 5:52am 20 June 2024