Add a settings cache context

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

I have fixed conflicts, failed pipeline issues, Please review.

@mstrelan The following line of code of a test was getting failed, not sure why, so i break it down and removed the container_yamls code.

      'example settings' => [
        [
          'container_yamls' => [
            DRUPAL_ROOT . '/sites/development.services.yml',
          ],
          'rebuild_access' => TRUE,
          'skip_permissions_hardening' => TRUE,
        ],
        'HyPdYHsolTJKyvFEtMMD1f4-E-Gvz8-1s1-lZya76JE',
      ],

Thanks
Samit K.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

False positive

Fixed csSpell failure reported by the bot

Left comments on MR

I am adding a change record.

I have added the CR as requested and added the return types to the MR. Setting back to 'Needs review'.

I'm not sure this is necessary anymore. It was an idea to solve 🐛 Admin Toolbar Tools breaks Dynamic Page Cache on Drupal 10.3 when update module is enabled Active but was addressed in 📌 Conditionally disable access to update manager routes Fixed . There is a chance there is still merit in doing this, but I think we'd need to find a real use case first.

Anyone able to address #15 for the use case?

Since the issue this intended to solve has already been resolved, and there have been no responses since marked PMNMI, I think we can assume there is no need to continue with this issue.

@mstrelan, thank you. I will delete the change record.