Add a settings cache context

Open on Drupal.org →

Created on 1 July 2024, 2 months ago

Problem/Motivation

Some things are uncacheable because they depend on settings. For example, \Drupal\update\Access\UpdateManagerAccessCheck::access. This leads to issues like 🐛 Admin Toolbar Tools breaks Dynamic Page Cache on Drupal 10.3 when update module is enabled Active .

Steps to reproduce

Proposed resolution

Add a SettingsCacheContext

Remaining tasks

Test coverage

User interface changes

API changes

Data model changes

Release notes snippet

✨ Feature request

Status

Needs work

Version

11.0 🔥

Component

Last updated 1 day ago

Maintained by
🇬🇧United Kingdom @catch
🇧🇪Belgium @kristiaanvandeneynde

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

!8594Add a settings cache context
Open
🇦🇺Australia mstrelan
updated 2 months ago

Comments & Activities

Issue created by @mstrelan
Merge request !8594Add settings cache context → (Open) created by mstrelan
Status changed to Needs work 2 months ago4:16am 1 July 2024
Comment 2 months ago →
🇦🇺Australia mstrelan
Pipeline finished with Success
2 months ago
Total: 576s
#212608
Pipeline finished with Failed
2 months ago
Total: 167s
#212652

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024