Dynamic Page Cache uncachable on Drupal 10.3 with Admin Toolbar Tools and Update modules

In Drupal 10.3 \Drupal\update\Access\UpdateManagerAccessCheck::access is called many times when rendering the toolbar, but not in 10.2.

Can you try reverting the commit from 🐛 Admin page access denied even when access is given to child items RTBC ? Seems like the most likely culprit here.

Added a failing test but GitLab CI is not enabled here so it's a bit harder to demonstrate.

Test passes on 10.2.x and fails on 10.3.x. It also fails after reverting 54a9077a on 10.3.x so it's not 🐛 Admin page access denied even when access is given to child items RTBC .

I narrowed it down to some commit in February then used git bisect to determine 🐛 Regression: Do not bypass route access with 'link to any page' permissions for menu links Needs work to be the cause.

I downloaded Drupal 10.3 using composer and installed using the DDEV and have not made any modifications to the services file to disable caching etc. but in the Drupal core itself, the response header X-Drupal-Dynamic-Cache: is UNCACHEABLE as a logged in user.

Looks like a Drupal core bug?

I have the problem described here 🐛 [Config] Warning: Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies. Active since updating to 10.3.0, I saw these lines in the stacktrace:

#17 /app/web/modules/contrib/admin_toolbar/src/Render/Element/AdminToolbar.php(47): Drupal\Core\Menu\MenuLinkTree->transform(Array, Array)
#18 [internal function]: Drupal\admin_toolbar\Render\Element\AdminToolbar::preRenderTray(Array)

I'm sure that these issues are related. Has anyone checked mrstrelan's comment #6?

#7 maybe not necessarily a core bug, but a change in core has led to this problem (as per #6). Updated the issue title so as not to point the blame on this module.

#8 does not look related to me.

This might be related to 📌 Don't hide permissions local tasks on bundles when no permissions are defined Needs work , worth trying the MR there.