- First commit to issue fork.
- 🇺🇦Ukraine voleger Ukraine, Rivne
Updated MR.
Also, I think it is worth to cover the scenario with a set of NULL value to the State storage. As per documentation for the `get` method, the returned NULL value means the key does not exist in the storage. So, should we warn users of false positives when the null value is trying to be set in State storage? - 🇮🇳India samit.310@gmail.com
Hi @voleger,
The test cases are failing, The main error is following
Expectation failed for method name is "getMultiple" when invoked 2 times. Method was expected to be called 2 times, actually called 0 times.
As i observe the getMultiple function is invoked with $this->keyValueStorage but values are asserting with $this->state.
Thanks
Samit K. - Merge request !93382386195: Add PHPUNIT test coverage for State API → (Open) created by samit.310@gmail.com
- Status changed to Needs review
12 days ago 11:59am 27 August 2024 - Status changed to Needs work
12 days ago 12:25pm 27 August 2024 - 🇺🇸United States smustgrave
The existing MR was already pointed to 11.x why start a new one? Fixes should just go into the original.
If going to start an exact new one though should review also.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to hidden.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to active.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no-test-coverage to hidden.
- Status changed to Needs review
11 days ago 7:10am 28 August 2024 - 🇮🇳India samit.310@gmail.com
Hi @smustgrave,
Thanks for the review, i have updated the code based on your suggestions. Also changed the previous branch
2386195-state-has-no
.Please review it again.
Thanks
Samit K. - Status changed to RTBC
4 days ago 3:20pm 3 September 2024