State has no dedicated test coverage

Updated MR.
Also, I think it is worth to cover the scenario with a set of NULL value to the State storage. As per documentation for the `get` method, the returned NULL value means the key does not exist in the storage. So, should we warn users of false positives when the null value is trying to be set in State storage?

Hi @voleger,

The test cases are failing, The main error is following

Expectation failed for method name is "getMultiple" when invoked 2 times.
Method was expected to be called 2 times, actually called 0 times.

As i observe the getMultiple function is invoked with $this->keyValueStorage but values are asserting with $this->state.

Thanks
Samit K.

The existing MR was already pointed to 11.x why start a new one? Fixes should just go into the original.

If going to start an exact new one though should review also.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to hidden.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no to active.

samit.310@gmail.com → changed the visibility of the branch 2386195-state-has-no-test-coverage to hidden.

Hi @smustgrave,

Thanks for the review, i have updated the code based on your suggestions. Also changed the previous branch 2386195-state-has-no.

Please review it again.

Thanks
Samit K.

Feedback appears to be addressed

Committed and pushed b155910d6a to 11.x and fece4f7ada to 10.4.x. Thanks!

🎉

🎉

Automatically closed - issue fixed for 2 weeks with no activity.