Title field description override in BlockContentBlock::blockForm() does nothing

While we're in this method the docblock is wrong as well:

  /**
   * Overrides \Drupal\Core\Block\BlockBase::blockForm().
   *
   * Adds body and description fields to the block configuration form.
   */

It doesn't do either of those things, it does allow the view mode to be set if more than one is available, but it probably should just be @inheritdoc.

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

I have moved #description to core/lib/Drupal/Core/Block/BlockPluginTrait.php as it seams generic.
Also changed the docblock of blockForm as it seams wrong.

Thanks
Samit K.

Personally I'm not sure the description really adds any value here, given it wasn't displayed before I don't think we should add it now.

Agree with #8

@longwave, @smustgrave,

I guess it will be useful for new (inexperienced) developers. Description will help them what will be the use of that title field. A kind of help text.

Thanks
Samit K.

I've removed that added descriptions and rebased. Since this is such a trivial change I'm RTBCing. Thanks!

Also agreed on removing the description. Committed/pushed to 11.x, thanks!

catch → closed merge request !9474

Automatically closed - issue fixed for 2 weeks with no activity.