Fix Call to an undefined method $this(Drupal\views\Plugin\views\HandlerBase)::getFormula()

needs rebase

samit.310@gmail.com → made their first commit to this issue’s fork.

Hi @andypost,

Rebase done, please review.

Thanks
Samit K.

Rebase is fine.

This isn't adding an interface as discussed in the previous issue, also the exception method doesn't tell you why not implementing the method is a problem, it should probably mention the property is defined (we probably need that with the interface too, it'll just be checking for the interface instead of the method).

I also don't understand from the code what the difference between $this->formula and $this->getFormula() is, is $this->formula a bool? If it is, then the interface check might be able to replace that completely (once the bc layer is removed).

How is this approach?

Know this is addressing phpstan issue but it is introducing a new interface and altering core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php do those not need change records or anything?

Tagging for issue summary as just based on title wasn't expecting new interface.

What in the issue summary needs to be changed?. It already states in the proposed resolution that an interface is added.

I think before making changes here the question in #10 should be addressed. Is this approach the correct one?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

See tag for issue summary.

This MR is now adding a new interface (which probably needs an MR), making a change to core/modules/views/src/Plugin/views/HandlerBase.php