- Issue created by @spokje
- Status changed to Needs work
9 months ago 7:32pm 17 January 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Status changed to Needs review
7 months ago 1:16pm 7 March 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Hi @andypost,
Rebase done, please review.
Thanks
Samit K. - Status changed to RTBC
7 months ago 2:26pm 7 March 2024 - Status changed to Needs work
7 months ago 3:47pm 7 March 2024 - ๐ฌ๐งUnited Kingdom catch
This isn't adding an interface as discussed in the previous issue, also the exception method doesn't tell you why not implementing the method is a problem, it should probably mention the property is defined (we probably need that with the interface too, it'll just be checking for the interface instead of the method).
I also don't understand from the code what the difference between $this->formula and $this->getFormula() is, is $this->formula a bool? If it is, then the interface check might be able to replace that completely (once the bc layer is removed).