- First commit to issue fork.
- Assigned to spokje
- 🇳🇱Netherlands spokje
Rerolled 3320569-2.patch against 11.x in new MR.
All patches after that show that c/p-ing rough example code isn't really helping, not even when tried repeatingly.
- Merge request !4250Issue #3320569: Fix views plugins PHPStan L0 issues → (Closed) created by spokje
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,553 pass - last update
over 1 year ago 29,801 pass - Issue was unassigned.
- Assigned to spokje
- Issue was unassigned.
- Status changed to Needs review
11 months ago 10:14am 3 January 2024 - 🇳🇱Netherlands spokje
Updated IS and MR and added draft CR.
That's enough two-lettered capitalized words for me to put it on NR.
- Status changed to RTBC
11 months ago 2:39pm 3 January 2024 - 🇺🇸United States smustgrave
CR reads well, IS is clear and matches MR.
So I believe this is OK.
Couldn't think of anyone two letter word to use haha.
8:20 4:46 Running- Status changed to Needs work
11 months ago 9:58am 4 January 2024 - 🇬🇧United Kingdom longwave UK
Added some feedback on the MR. Maybe we should split this into two issues.
- Status changed to Needs review
10 months ago 5:48pm 11 January 2024 - Status changed to Needs work
10 months ago 6:48pm 11 January 2024 - 🇺🇸United States smustgrave
2 small nitpicky stuff.
Rest looks fine though
Probably good to self RTBC after those 2.
- Status changed to RTBC
10 months ago 3:40pm 20 January 2024 - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I read the IS, the comments and MR. I didn't find any unanswered questions or other work to do.
The change record does need to be updated. It should state that using the operator method without the interface will throw an exception in Drupal 11.
- Status changed to Needs work
9 months ago 2:55am 19 February 2024 - 🇳🇿New Zealand quietone
And the title of the CR could be more specific about where the operators method is used. Perhaps this is better, "Classes using operators() when extending \Drupal\views\Plugin\views\filter\FilterPluginBase must implement FilterOperatorsInterface'?
- Status changed to RTBC
9 months ago 4:31am 19 February 2024 - First commit to issue fork.
- Status changed to Fixed
9 months ago 12:04pm 5 March 2024 - 🇬🇧United Kingdom catch
I updated the deprecation to throwing an exception in 12.0.0 instead of 11.0.0, otherwise looks great. Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.