- Status changed to Needs review
about 1 year ago 11:14am 29 February 2024 - ๐บ๐ฆUkraine HitchShock Ukraine
Definitely, this is a major issue, because it can cause mismatching of the result types and can cause mistakes in the conditions.
For example, a condition like$current_account->id() === $entity->getOwnerId()
could be invalid because of type mismatching in the case when it must be valid according to the hin for the function's result type.Also, it can cause similar mistakes in the core, for example ๐ Media entity owner access check Needs work
The patch #2 is more valid at the moment I think, so I hide the patch #7.
The patch #7, in general, is a good idea, but we need to recheck and fix all issues that it will cause, like test failures.
My opinion is to merge patch #2 ASAP to not confuse developers and to give a correct type hint and create a separate ticket for #7
Set a ticket to RTB to hurry up the process a bit
- Status changed to Needs work
about 1 year ago 11:27am 29 February 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Status changed to Needs review
8 months ago 8:33am 20 August 2024 - ๐ฎ๐ณIndia prashant.c Dharamshala
Just wondering, when this returns
string
and when it returnsint
value. Thinking in the context of why we need have both the return typesint
andstring
also. - Status changed to Needs work
7 months ago 1:42pm 26 August 2024 - ๐บ๐ธUnited States smustgrave
I don't believe it's suppose to return a string, that seems like a bug. Don't think we should update the docs to be wrong to just to cover the bug that's currently there.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Should we cover the bug in this issue itself or create a new one?