- ๐ซ๐ทFrance prudloff Lille
#14 creates an infinite redirect loop because
$this->account->isAuthenticated()
is always true now so it always sends aRedirectResponse
.
I thinkMaintenanceModeSubscriber
serves no other purpose and could be entirely removed. - last update
12 months ago Patch Failed to Apply - last update
12 months ago Patch Failed to Apply - Merge request !8609Issue #3057267: User logout during maintenance mode โ (Open) created by prudloff
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !8876057267: User logout during maintenance mode โ (Open) created by samit.310@gmail.com
- Status changed to Needs review
4 months ago 1:45pm 22 July 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
HI,
We have permission provided by Drupal Use the site in maintenance mode(
access site in maintenance mode
) that allow any user to work on maintenance mode, A simple change can fix this user logout issue,Here all the users who have Use the site in maintenance mode(
access site in maintenance mode
) permission, will not logout if the site goes to maintenance mode.Here is the PR link: https://git.drupalcode.org/project/drupal/-/merge_requests/8876/diffs
Thanks
Samit K. - ๐จ๐ญSwitzerland handkerchief
@samit.310@gmail.com But not logging out does not automatically mean that users should continue to use the website despite maintenance.
Example from practice:
Website is briefly switched to maintenance mode several times a day because automatic backups are performed. However, it is correct that during backups, no user administers the website and therefore should not have the permission โUse the site in maintenance modeโ. But the users should not all be logged out just because maintenance mode was switched on briefly. If you have a website with a community where many users are logged in, then they are automatically logged out several times a day. - Status changed to Needs work
4 months ago 2:58pm 23 July 2024 - ๐บ๐ธUnited States smustgrave
Only briefly skimmed but any change will need test coverage.
Also issue summary appears incomplete, recommend using default issue template. Sounds like from previous comment MR solution isn't along the idea so definitely needs a summary update.
- ๐ฎ๐ณIndia samit.310@gmail.com
Hi @handkerchief,
Agree with your point, but here the idea is the only trusted or some specific user roles have this permission Use the site in maintenance mode(
access site in maintenance mode
).The functionality will remain the same for other users, meaning whenever the maintenance mode will on all the users except those with the above permission will logout.
Thanks
Samit K.