The design of tag links needs improvement.

Created on 14 November 2023, about 1 year ago
Updated 20 August 2024, 3 months ago

Problem/Motivation

We need to make tag links look better. Let's improve how they appear on the page, like choosing nice colors and organizing them well so it's easy for people to click and find what they're looking for.
I have attached a screenshot for better reference.

Steps to reproduce

  1. Install theme
  2. create article node
  3. check the tag.

✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Nitin shrivastava

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Nitin shrivastava
  • @nitin-shrivastava opened merge request.
  • Status changed to Needs review about 1 year ago
  • 🇮🇳India Arun Velusamy

    I've confirmed MR !29, and it appears to be satisfactory. Additionally, I've included screenshots for reference. I recommend enhancing the visibility of tags by applying the following CSS code.

    ul.links.inline{
    	padding: 0px;
    	display: flex;
    	gap: 16px;
    }
    ul.links.inline li{
    	list-style-type: none;
    }
    ul.links.inline li a {
        color: #000;
        border: 1px solid #DADFE1;
        font-size: 17px;
        padding: 4px 20px;
        vertical-align: middle;
        text-decoration: none;
        font-weight: 400;
    }
    ul.links.inline li a:hover {
    	color: #fff;
    	border: 1px solid #000;
    	background: #000000;
    }

    I have added the screenshot after applied the above css also.
    Please review

  • Status changed to Needs work 5 months ago
  • 🇮🇳India Nupur Badola

    Reviewed MR!29, the CSS for tags is not working as expected.

  • Assigned to ravi kant
  • 🇮🇳India ravi kant Jaipur
  • Merge request !30Fixed tags issue → (Open) created by ravi kant
  • 🇮🇳India ravi kant Jaipur

    ravi kant → changed the visibility of the branch 1.0.x to hidden.

  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • 🇮🇳India ravi kant Jaipur

    Fixed the issue and created MR !30

  • Status changed to Needs work 5 months ago
  • 🇮🇳India pray_12

    Hi @ravikant, Applied the MR, the css styles are overlapping. Attaching Screenshot for reference. Thank you!

  • First commit to issue fork.
  • Status changed to Needs review 3 months ago
  • Hi,
    I have resolved the overlapping issue that was mentioned in #10 ✨ The design of tag links needs improvement. Needs work . I found the issue occurred when the tag had multiple values with or without tag label. I've updated MR!30 and included ss for reference.
    Please have a look. Thanks

  • 🇮🇳India Tirupati_Singh

    Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the patch the styling has been improved for the tags. However, the tags design is overflowing on mobile devices as shown in the attached screenshot. I've attached screenshots of the before and after fixes for reference. Since the issue persists for the mobile devices, I'm moving the issue status to Needs work.

  • Hello @tirupati_singh,
    I've fixed the tags design is overflowing on mobile devices issue that you've mentioned in #13 ✨ The design of tag links needs improvement. Needs work . I found that the tags just changed the cursor pointer on hover whereas the read more button showed border color change while hovering. Therefore, I've implemented the hover effect for the tags. Please review.

  • 🇮🇳India Tirupati_Singh

    Hi, I've tested the new changes made in the provided MR and confirm that the tags overflow design for mobile devices issue has been resolved successfully. Additionally, the hover effect for tags has also been implemented and its working fine. I'm attaching the after fixes screenshot for reference. Moving the issue status to RTBC as the changes are working fine.

    Thanks!

Production build 0.71.5 2024