- Issue created by @Nitin shrivastava
- @nitin-shrivastava opened merge request.
- Status changed to Needs review
about 1 year ago 11:32am 14 November 2023 - 🇮🇳India Arun Velusamy
I've confirmed MR !29, and it appears to be satisfactory. Additionally, I've included screenshots for reference. I recommend enhancing the visibility of tags by applying the following CSS code.
ul.links.inline{ padding: 0px; display: flex; gap: 16px; } ul.links.inline li{ list-style-type: none; } ul.links.inline li a { color: #000; border: 1px solid #DADFE1; font-size: 17px; padding: 4px 20px; vertical-align: middle; text-decoration: none; font-weight: 400; } ul.links.inline li a:hover { color: #fff; border: 1px solid #000; background: #000000; }
I have added the screenshot after applied the above css also.
Please review - Status changed to Needs work
5 months ago 12:43pm 4 June 2024 - 🇮🇳India Nupur Badola
Reviewed MR!29, the CSS for tags is not working as expected.
- Assigned to ravi kant
- 🇮🇳India ravi kant Jaipur
ravi kant → changed the visibility of the branch 1.0.x to hidden.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 11:23am 11 June 2024 - Status changed to Needs work
5 months ago 5:32am 12 June 2024 - 🇮🇳India pray_12
Hi @ravikant, Applied the MR, the css styles are overlapping. Attaching Screenshot for reference. Thank you!
- First commit to issue fork.
- Status changed to Needs review
3 months ago 7:37pm 20 August 2024 Hi,
I have resolved the overlapping issue that was mentioned in #10 ✨ The design of tag links needs improvement. Needs work . I found the issue occurred when the tag had multiple values with or without tag label. I've updated MR!30 and included ss for reference.
Please have a look. Thanks- 🇮🇳India Tirupati_Singh
Hi, I've applied the provided MR as a patch and it applied cleanly with no errors. After applying the patch the styling has been improved for the tags. However, the tags design is overflowing on mobile devices as shown in the attached screenshot. I've attached screenshots of the before and after fixes for reference. Since the issue persists for the mobile devices, I'm moving the issue status to Needs work.
Hello @tirupati_singh,
I've fixed the tags design is overflowing on mobile devices issue that you've mentioned in #13 ✨ The design of tag links needs improvement. Needs work . I found that the tags just changed the cursor pointer on hover whereas the read more button showed border color change while hovering. Therefore, I've implemented the hover effect for the tags. Please review.- 🇮🇳India Tirupati_Singh
Hi, I've tested the new changes made in the provided MR and confirm that the tags overflow design for mobile devices issue has been resolved successfully. Additionally, the hover effect for tags has also been implemented and its working fine. I'm attaching the after fixes screenshot for reference. Moving the issue status to RTBC as the changes are working fine.
Thanks!