Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 6 July 2023, over 1 year ago
Updated 21 September 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/webform_preset/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | Line exceeds 80 characters; contains 99 characters
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/webform_preset/src/Utility/CronTool.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Missing function doc comment
31 | ERROR | [x] Missing function doc comment
36 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...ar/www/html/vb/d_cont/webform_preset/src/Entity/WebformPresetInterface.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace declaration
9 | ERROR | [x] Missing interface doc comment
11 | ERROR | [x] Missing function doc comment
13 | ERROR | [x] Missing function doc comment
15 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Missing function doc comment
19 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/webform_preset/src/Entity/WebformPreset.php
--------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
--------------------------------------------------------------------------------
70 | ERROR | [x] Space after closing parenthesis of function call prohibited
71 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n
| | ;"
76 | ERROR | [x] Space after closing parenthesis of function call prohibited
77 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n
| | ;"
82 | ERROR | [x] Space after closing parenthesis of function call prohibited
83 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n
| | ;"
89 | ERROR | [x] Space after closing parenthesis of function call prohibited
90 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n
| | ;"
95 | ERROR | [x] Missing function doc comment
96 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment
| | */" or "// Comment" instead
100 | ERROR | [x] Missing function doc comment
105 | ERROR | [x] Missing function doc comment
115 | ERROR | [x] Missing function doc comment
120 | ERROR | [x] Missing function doc comment
124 | ERROR | [x] Missing function doc comment
128 | ERROR | [x] Missing function doc comment
132 | ERROR | [x] Missing function doc comment
138 | ERROR | [x] Missing function doc comment
143 | ERROR | [x] Missing function doc comment
147 | ERROR | [x] Missing function doc comment
151 | ERROR | [x] Missing function doc comment
178 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...t/webform_preset/src/Plugin/WebformHandler/WebformPresetWebformHandler.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------------
12 | WARNING | [x] Unused use statement
18 | ERROR | [ ] Missing short description in doc comment
30 | ERROR | [ ] Missing member variable doc comment
32 | ERROR | [x] Missing function doc comment
42 | ERROR | [x] Space after closing parenthesis of function call prohibited
43 | ERROR | [x] Space found before semicolon; expected ");" but found ")\n
| | ;"
49 | ERROR | [x] Missing function doc comment
64 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/webform_preset/webform_preset.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 110ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_preset/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    Satish_kumar

    Hii, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

    These are the steps I followed:

    1. Took clone from git version 1.0.x in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/webform_preset/

    3. Applied your patch and, again ran phpcs command

    found no errors.

    Moving to RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024