Fix the issues reported by phpcs

FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/AdvbanIpManager.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Component\Render\FormattableMarkup. 10 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanSettingsForm.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Core\Config\ConfigFactoryInterface. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanSearchForm.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url. --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanDelete.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\advban\AdvbanIpManagerInterface. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanAdmin.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\advban\AdvbanIpManagerInterface. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanEdit.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\advban\AdvbanIpManagerInterface. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/src/Form/AdvbanDeleteAll.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\advban\AdvbanIpManagerInterface. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/advban/tests/src/Functional/IpAddressBlockingTest.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is | | Drupal\Core\StringTranslation\StringTranslationTrait. -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- Time: 241ms; Memory: 12MB

Comments & Activities

Issue created by @roshni27
Issue was unassigned.
Status changed to Needs review over 1 year ago12:55pm 7 July 2023
Comment over 1 year ago →
🇮🇳India roshni27
Status changed to RTBC over 1 year ago11:24am 17 August 2023
Comment over 1 year ago →
Satish_kumar
Hi @roshni27, I have applied your patch.

These are the steps I followed:

1. Took clone from git version 8.x-1 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/advan/

3. Applied patch and again ran phpcs command.

found no errors.

Moving this to RTBC.
Comment about 1 year ago →
🇲🇩Moldova andrei.vesterli Chisinau
Hi @goodboy

Will you be able to merge the patch in the module?

Regards,
Andrei
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
Patch Failed to Apply
Status changed to Needs work 10 months ago12:14pm 28 January 2024
Comment 10 months ago →
🇺🇦Ukraine goodboy Kharkiv, Ukraine
@andrei.vesterli, the patch can't be applied.
I've tried to do phpcs and got a patch file with 222 rows.
So, please, reroll your patch
First commit to issue fork.
Status changed to Needs review 10 months ago10:16am 30 January 2024
Comment 10 months ago →
🇮🇳India viren18febS
I have fixed all the issues. please review.
Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
3 pass
Comment 10 months ago →
System Message

goodboy → committed 984d4471 on 8.x-1.x authored by viren18febS →
Issue #3373211 by viren18febS, roshni27: Fix the issues reported by...
Status changed to Fixed 10 months ago4:41pm 30 January 2024
Comment 10 months ago →
🇺🇦Ukraine goodboy Kharkiv, Ukraine
@viren18febS, thanks, fixed.
Please, run test for a patch
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities