- Issue created by @urvashi_vora
- last update
about 1 year ago 2 fail Hii, @urvashi_vora
These are the steps I followed:
1. Took clone from git version 1.0.x in drupal 10.1.x
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/dmg/
3. Applied your patch and, again ran phpcs command
found errors.
4. Fixed the errors and provide the patch.
Please Review.
The last submitted patch, 2: coding-standard-fixed-3372428-2.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
about 1 year ago 2 fail - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Providing new Patch file with fixes for 1.0.x
Please review The last submitted patch, 5: phpcs-issue-fixes-3372428-5.patch, failed testing. View results โ
- Assigned to mohd sahzad
- Status changed to Needs work
about 1 year ago 10:13am 22 September 2023 - First commit to issue fork.
- Issue was unassigned.
- ๐ฎ๐ณIndia mohd sahzad
I have updated this module for Fix the issues reported by phpcs please review patch6
- last update
about 1 year ago 1 pass - last update
about 1 year ago Composer error. Unable to continue. - last update
about 1 year ago 1 pass - ๐ฎ๐ณIndia aayushDrupal
Hi Mohd Sahzad,
Your patch #6 has been successfully applied, but it does not fully resolve the errors flagged by phpcs. Please review the attached screenshot for verification.Moving to needs work.
Please review. - Assigned to akshay.singh
- last update
about 1 year ago 2 fail - @akshaysingh opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- last update
about 1 year ago 2 fail - @chetan-11 opened merge request.
- Status changed to Needs review
about 1 year ago 1:02pm 28 September 2023 - Status changed to RTBC
about 1 year ago 11:37am 29 September 2023 - ๐ฎ๐ณIndia aayushDrupal
I have reviewed this module for phpcs errors and there are no remaining errors. Please check the attached screenshot.
Moving to RTBC.
Thanks - last update
about 1 year ago 2 fail - last update
about 1 year ago Composer error. Unable to continue. - last update
about 1 year ago 2 fail