Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 7 July 2023, over 1 year ago
Updated 27 August 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/README.md
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...ar/www/html/vb/d_cont/drupal_sheetjs/tests/src/Browser/BackendPageTest.php
--------------------------------------------------------------------------------
FOUND 27 ERRORS AND 4 WARNINGS AFFECTING 24 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [x] Opening brace should be on the same line as the declaration
11 | ERROR | [ ] Missing short description in doc comment
14 | WARNING | [ ] Property name "$_testPath" should not be prefixed with an
| | underscore to indicate visibility
14 | ERROR | [ ] Class property $_testPath should use lowerCamel naming
| | without underscores
16 | ERROR | [ ] Missing short description in doc comment
19 | WARNING | [ ] Property name "$_submitValue" should not be prefixed with
| | an underscore to indicate visibility
19 | ERROR | [ ] Class property $_submitValue should use lowerCamel naming
| | without underscores
21 | ERROR | [ ] Missing short description in doc comment
24 | WARNING | [ ] Property name "$_config_factory" should not be prefixed
| | with an underscore to indicate visibility
24 | ERROR | [ ] Class property $_config_factory should use lowerCamel
| | naming without underscores
26 | ERROR | [ ] Missing short description in doc comment
31 | ERROR | [ ] Missing short description in doc comment
36 | ERROR | [x] Missing function doc comment
37 | WARNING | [x] 'TODO: Change the autogenerated stub' should match the
| | format '@todo Fix problem X here.'
37 | ERROR | [x] Comments may not appear after statements
37 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
43 | ERROR | [ ] Missing short description in doc comment
47 | ERROR | [x] Opening brace should be on the same line as the declaration
52 | ERROR | [ ] Missing short description in doc comment
58 | ERROR | [x] Opening brace should be on the same line as the declaration
66 | ERROR | [ ] Missing short description in doc comment
71 | ERROR | [x] Opening brace should be on the same line as the declaration
84 | ERROR | [ ] Private method name "BackendPageTest::_testFormTemplate" is
| | not in lowerCamel format
84 | ERROR | [x] Missing function doc comment
92 | ERROR | [ ] Missing short description in doc comment
93 | ERROR | [ ] Description for the @return value is missing
96 | ERROR | [ ] Private method name "BackendPageTest::_createAdminuser" is
| | not in lowerCamel format
96 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
97 | ERROR | [ ] The array declaration extends to column 81 (the limit is
| | 80). The array content should be split up over multiple
| | lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/tests/src/Browser/FrontPageTest.php
--------------------------------------------------------------------------------
FOUND 48 ERRORS AND 3 WARNINGS AFFECTING 30 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
11 | WARNING | [ ] Property name "$_testCustomPath" should not be prefixed
| | with an underscore to indicate visibility
11 | ERROR | [ ] Class property $_testCustomPath should use lowerCamel
| | naming without underscores
11 | ERROR | [ ] Missing member variable doc comment
12 | WARNING | [ ] Property name "$_testDefaultPath" should not be prefixed
| | with an underscore to indicate visibility
12 | ERROR | [ ] Class property $_testDefaultPath should use lowerCamel
| | naming without underscores
12 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [ ] Missing short description in doc comment
19 | ERROR | [ ] Missing short description in doc comment
24 | ERROR | [x] Missing function doc comment
25 | WARNING | [x] 'TODO: Change the autogenerated stub' should match the
| | format '@todo Fix problem X here.'
25 | ERROR | [x] Comments may not appear after statements
25 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
30 | ERROR | [ ] Missing short description in doc comment
34 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
42 | ERROR | [ ] Missing short description in doc comment
48 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
59 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
59 | ERROR | [x] There should be no white space after an opening "("
59 | ERROR | [x] There should be no white space before a closing ")"
59 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
62 | ERROR | [x] There should be no white space after an opening "("
62 | ERROR | [x] There should be no white space before a closing ")"
65 | ERROR | [x] There should be no white space after an opening "("
65 | ERROR | [x] There should be no white space before a closing ")"
68 | ERROR | [x] There should be no white space after an opening "("
68 | ERROR | [x] There should be no white space before a closing ")"
94 | ERROR | [ ] Missing short description in doc comment
99 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
117 | ERROR | [x] Missing function doc comment
118 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
128 | ERROR | [x] Missing function doc comment
129 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
139 | ERROR | [ ] Private method name
| | "FrontPageTest::_testPageTypeTestTemplate" is not in
| | lowerCamel format
139 | ERROR | [x] Missing function doc comment
139 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
139 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
139 | ERROR | [x] There should be no white space after an opening "("
139 | ERROR | [x] There should be no white space before a closing ")"
139 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
147 | ERROR | [x] There should be no white space after an opening "("
147 | ERROR | [x] There should be no white space before a closing ")"
148 | ERROR | [x] Concat operator must be surrounded by a single space
148 | ERROR | [x] Concat operator must be surrounded by a single space
153 | ERROR | [ ] Missing short description in doc comment
154 | ERROR | [ ] Description for the @return value is missing
157 | ERROR | [ ] Private method name "FrontPageTest::_createAdminuser" is
| | not in lowerCamel format
157 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
158 | ERROR | [ ] The array declaration extends to column 81 (the limit is
| | 80). The array content should be split up over multiple
| | lines
159 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/templates/test_custom.html.twig
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
43 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------

FILE: .../vb/d_cont/drupal_sheetjs/templates/drupal_sheetjs_custom_loader.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
32 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ww/html/vb/d_cont/drupal_sheetjs/templates/drupal_sheetjs_loader.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
30 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ml/vb/d_cont/drupal_sheetjs/templates/test/drupal_sheetjs_loader.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
23 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/templates/test.html.twig
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
43 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/src/Helper/DrupalSheetJsHelper.php
--------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
5 | ERROR | [x] Missing class doc comment
6 | ERROR | [x] Opening brace should be on the same line as the declaration
7 | ERROR | [ ] Class property $dest_table_id should use lowerCamel naming
| | without underscores
7 | ERROR | [ ] Missing member variable doc comment
8 | ERROR | [ ] Class property $submit_element_id should use lowerCamel
| | naming without underscores
8 | ERROR | [ ] Missing member variable doc comment
9 | ERROR | [ ] Class property $submit_full_element_id should use lowerCamel
| | naming without underscores
9 | ERROR | [ ] Missing member variable doc comment
10 | ERROR | [ ] Class property $current_file_name should use lowerCamel
| | naming without underscores
10 | ERROR | [ ] Missing member variable doc comment
11 | ERROR | [ ] Class property $full_data_file_name should use lowerCamel
| | naming without underscores
11 | ERROR | [ ] Missing member variable doc comment
12 | ERROR | [ ] Class property $export_type should use lowerCamel naming
| | without underscores
12 | ERROR | [ ] Missing member variable doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 138 ERRORS AND 7 WARNINGS AFFECTING 63 LINES
--------------------------------------------------------------------------------
14 | ERROR | [ ] Missing short description in doc comment
15 | ERROR | [ ] Description for the @return value is missing
21 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [ ] Description for the @return value is missing
28 | ERROR | [ ] Missing short description in doc comment
29 | ERROR | [ ] Missing parameter comment
30 | ERROR | [ ] Missing parameter comment
30 | ERROR | [x] Data types in @param tags need to be fully namespaced
31 | ERROR | [ ] Description for the @return value is missing
42 | WARNING | [ ] Avoid backslash escaping in translatable strings when
| | possible, use "" quotes instead
94 | ERROR | [ ] Missing short description in doc comment
95 | ERROR | [ ] Missing parameter comment
96 | ERROR | [ ] Missing parameter comment
96 | ERROR | [x] Data types in @param tags need to be fully namespaced
109 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
117 | ERROR | [x] There should be no white space after an opening "("
117 | ERROR | [x] There should be no white space after an opening "("
117 | ERROR | [x] There should be no white space before a closing ")"
117 | ERROR | [x] There should be no white space before a closing ")"
118 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
121 | ERROR | [x] There should be no white space after an opening "("
121 | ERROR | [x] There should be no white space after an opening "("
121 | ERROR | [x] There should be no white space before a closing ")"
121 | ERROR | [x] There should be no white space before a closing ")"
122 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
125 | ERROR | [x] There should be no white space after an opening "("
125 | ERROR | [x] There should be no white space after an opening "("
125 | ERROR | [x] There should be no white space before a closing ")"
125 | ERROR | [x] There should be no white space before a closing ")"
126 | ERROR | [x] There should be no white space after an opening "("
126 | ERROR | [x] There should be no white space after an opening "("
126 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
126 | ERROR | [x] There should be no white space before a closing ")"
126 | ERROR | [x] There should be no white space before a closing ")"
129 | ERROR | [x] There should be no white space after an opening "("
129 | ERROR | [x] There should be no white space after an opening "("
129 | ERROR | [x] There should be no white space before a closing ")"
129 | ERROR | [x] There should be no white space before a closing ")"
130 | ERROR | [x] There should be no white space after an opening "("
130 | ERROR | [x] There should be no white space after an opening "("
130 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
130 | ERROR | [x] There should be no white space before a closing ")"
130 | ERROR | [x] There should be no white space before a closing ")"
133 | ERROR | [x] There should be no white space after an opening "("
133 | ERROR | [x] There should be no white space after an opening "("
133 | ERROR | [x] There should be no white space before a closing ")"
133 | ERROR | [x] There should be no white space before a closing ")"
134 | ERROR | [x] There should be no white space after an opening "("
134 | ERROR | [x] There should be no white space after an opening "("
134 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
134 | ERROR | [x] There should be no white space before a closing ")"
134 | ERROR | [x] There should be no white space before a closing ")"
137 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
145 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
153 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
164 | ERROR | [ ] Missing short description in doc comment
165 | ERROR | [ ] Missing parameter comment
166 | ERROR | [ ] Missing parameter comment
166 | ERROR | [x] Data types in @param tags need to be fully namespaced
170 | ERROR | [x] Expected 1 space after "="; 2 found
170 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
170 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
185 | ERROR | [ ] Missing short description in doc comment
185 | ERROR | [ ] Parameter $msg is not described in comment
186 | ERROR | [ ] Missing parameter comment
187 | ERROR | [ ] Missing parameter comment
188 | ERROR | [ ] Parameter comment must start with a capital letter
188 | ERROR | [x] Parameter comment must be on the next line
188 | ERROR | [x] Parameter comment must end with a full stop
189 | ERROR | [ ] Missing parameter comment
189 | ERROR | [x] Data types in @param tags need to be fully namespaced
191 | ERROR | [ ] Private method name "SettingsForm::_cssIdValidator" is not
| | in lowerCamel format
191 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
199 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE"
| | but found "false"
200 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
204 | ERROR | [ ] Missing short description in doc comment
205 | ERROR | [ ] Missing parameter comment
205 | ERROR | [x] Data types in @param tags need to be fully namespaced
206 | ERROR | [ ] Description for the @return value is missing
208 | ERROR | [ ] Private method name "SettingsForm::_getDestTableId" is not
| | in lowerCamel format
208 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
208 | ERROR | [x] There should be no white space after an opening "("
208 | ERROR | [x] There should be no white space before a closing ")"
208 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
209 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
209 | ERROR | [x] There should be no white space after an opening "("
209 | ERROR | [x] There should be no white space before a closing ")"
209 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
209 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
212 | ERROR | [ ] Missing short description in doc comment
213 | ERROR | [ ] Missing parameter comment
213 | ERROR | [x] Data types in @param tags need to be fully namespaced
214 | ERROR | [ ] Description for the @return value is missing
216 | ERROR | [ ] Private method name "SettingsForm::_getSubmitElementId" is
| | not in lowerCamel format
216 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
216 | ERROR | [x] There should be no white space after an opening "("
216 | ERROR | [x] There should be no white space before a closing ")"
216 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
217 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
217 | ERROR | [x] There should be no white space after an opening "("
217 | ERROR | [x] There should be no white space before a closing ")"
217 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
217 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
220 | ERROR | [ ] Missing short description in doc comment
221 | ERROR | [ ] Missing parameter comment
221 | ERROR | [x] Data types in @param tags need to be fully namespaced
222 | ERROR | [ ] Description for the @return value is missing
224 | ERROR | [ ] Private method name
| | "SettingsForm::_getSubmitFullElementId" is not in
| | lowerCamel format
224 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
224 | ERROR | [x] There should be no white space after an opening "("
224 | ERROR | [x] There should be no white space before a closing ")"
224 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
225 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
225 | ERROR | [x] There should be no white space after an opening "("
225 | ERROR | [x] There should be no white space before a closing ")"
225 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
225 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
228 | ERROR | [ ] Missing short description in doc comment
229 | ERROR | [ ] Missing parameter comment
229 | ERROR | [x] Data types in @param tags need to be fully namespaced
230 | ERROR | [ ] Description for the @return value is missing
232 | ERROR | [ ] Private method name "SettingsForm::_getCurrentFileName" is
| | not in lowerCamel format
232 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
232 | ERROR | [x] There should be no white space after an opening "("
232 | ERROR | [x] There should be no white space before a closing ")"
232 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
233 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
233 | ERROR | [x] There should be no white space after an opening "("
233 | ERROR | [x] There should be no white space before a closing ")"
233 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
233 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
236 | ERROR | [ ] Missing short description in doc comment
237 | ERROR | [ ] Missing parameter comment
237 | ERROR | [x] Data types in @param tags need to be fully namespaced
238 | ERROR | [ ] Description for the @return value is missing
240 | ERROR | [ ] Private method name "SettingsForm::_getFullDataFileName"
| | is not in lowerCamel format
240 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
240 | ERROR | [x] There should be no white space after an opening "("
240 | ERROR | [x] There should be no white space before a closing ")"
240 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
241 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
241 | ERROR | [x] There should be no white space after an opening "("
241 | ERROR | [x] There should be no white space before a closing ")"
241 | ERROR | [x] Space after closing parenthesis of function call
| | prohibited
241 | ERROR | [x] Space found before semicolon; expected ");" but found ")
| | ;"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 97 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...w/html/vb/d_cont/drupal_sheetjs/src/Controller/DrupalSheetjsController.php
--------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [x] Opening brace should be on the same line as the declaration
10 | ERROR | [ ] Missing short description in doc comment
11 | ERROR | [ ] Description for the @return value is missing
13 | ERROR | [x] Expected 1 blank line before function; 0 found
13 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
22 | ERROR | [ ] Missing short description in doc comment
23 | ERROR | [ ] Description for the @return value is missing
25 | ERROR | [ ] Public method name "DrupalSheetjsController::test_custom" is
| | not in lowerCamel format
25 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
34 | ERROR | [ ] Missing short description in doc comment
35 | ERROR | [ ] Description for the @return value is missing
35 | ERROR | [x] Data types in @return tags need to be fully namespaced
37 | ERROR | [ ] Private method name
| | "DrupalSheetjsController::_getDrupalSheetjsConfigDataService"
| | is not in lowerCamel format
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...d_cont/drupal_sheetjs/src/EventSubscriber/DrupalSheetjsEventSubscriber.php
--------------------------------------------------------------------------------
FOUND 20 ERRORS AND 2 WARNINGS AFFECTING 22 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
16 | ERROR | [x] Doc comment short description must end with a full stop
17 | ERROR | [x] There must be exactly one blank line before the tags in a
| | doc comment
18 | WARNING | [ ] The class short comment should describe what the class
| | does and not simply repeat the class name
20 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
23 | ERROR | [ ] Missing short description in doc comment
28 | ERROR | [ ] Missing short description in doc comment
33 | ERROR | [ ] Missing short description in doc comment
38 | ERROR | [ ] Missing short description in doc comment
39 | ERROR | [ ] Missing parameter comment
40 | ERROR | [ ] Missing parameter comment
41 | ERROR | [ ] Missing parameter comment
49 | ERROR | [ ] Missing short description in doc comment
50 | ERROR | [ ] Missing parameter comment
53 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
67 | ERROR | [ ] Missing short description in doc comment
68 | ERROR | [ ] Missing parameter comment
71 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
75 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment
| | */" or "// Comment" instead
88 | WARNING | [ ] Unused variable $full_data.
100 | ERROR | [ ] Missing short description in doc comment
101 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../html/vb/d_cont/drupal_sheetjs/src/Services/DrupalSheetjsConfigService.php
--------------------------------------------------------------------------------
FOUND 27 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
8 | ERROR | [x] Opening brace should be on the same line as the declaration
10 | ERROR | [x] Missing function doc comment
10 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found
10 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
10 | ERROR | [x] There should be no white space after an opening "("
10 | ERROR | [x] There should be no white space before a closing ")"
10 | ERROR | [x] Expected 0 spaces before closing parenthesis; 1 found
12 | ERROR | [x] There should be no white space after an opening "("
12 | ERROR | [x] There should be no white space before a closing ")"
18 | ERROR | [ ] Private method name
| | "DrupalSheetjsConfigService::_getDefaultData" is not in
| | lowerCamel format
18 | ERROR | [x] Missing function doc comment
18 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
30 | ERROR | [x] Expected 1 space before ":"; 0 found
40 | ERROR | [ ] Private method name
| | "DrupalSheetjsConfigService::_getTestData" is not in
| | lowerCamel format
40 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Expected 0 spaces before opening parenthesis; 1 found
41 | ERROR | [x] There should be no white space after an opening "["
41 | ERROR | [x] Comma not allowed after last value in single-line array
| | declaration
41 | ERROR | [x] Expected one space after the comma, 0 found
41 | ERROR | [x] There should be no white space before a closing "]"
43 | ERROR | [x] Comma not allowed after last value in single-line array
| | declaration
43 | ERROR | [x] Expected one space after the comma, 0 found
44 | ERROR | [x] Comma not allowed after last value in single-line array
| | declaration
44 | ERROR | [x] Expected one space after the comma, 0 found
45 | ERROR | [x] Comma not allowed after last value in single-line array
| | declaration
45 | ERROR | [x] Expected one space after the comma, 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 25 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/drupal_sheetjs.module
--------------------------------------------------------------------------------
FOUND 14 ERRORS AND 3 WARNINGS AFFECTING 13 LINES
--------------------------------------------------------------------------------
19 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment
| | */" or "// Comment" instead
24 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 11 spaces but found 1 space
25 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 8 spaces but found 18 spaces
26 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 1 space but found 11 spaces
47 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | NULL
53 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | NULL
62 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
62 | ERROR | [ ] Missing parameter comment
62 | ERROR | [ ] Missing parameter type
65 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 11 spaces but found 1 space
66 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 4 spaces but found 1 space
66 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced
| | with use statements
67 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 1 space but found 11 spaces
68 | ERROR | [x] There should be no white space after an opening "("
68 | ERROR | [x] There should be no white space before a closing ")"
69 | ERROR | [x] Expected 1 space after "="; 2 found
71 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 141ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig drupal_sheetjs/

Remaining tasks

Patch review

and

FILE: ...ar/www/html/vb/d_cont/drupal_sheetjs/tests/src/Browser/BackendPageTest.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
19 | WARNING | Property name "$_testPath" should not be prefixed with an
| | underscore to indicate visibility
19 | ERROR | Class property $_testPath should use lowerCamel naming without
| | underscores
26 | WARNING | Property name "$_submitValue" should not be prefixed with an
| | underscore to indicate visibility
26 | ERROR | Class property $_submitValue should use lowerCamel naming
| | without underscores
33 | WARNING | Property name "$_config_factory" should not be prefixed with
| | an underscore to indicate visibility
33 | ERROR | Class property $_config_factory should use lowerCamel naming
| | without underscores
109 | ERROR | Private method name "BackendPageTest::_testFormTemplate" is
| | not in lowerCamel format
125 | ERROR | Private method name "BackendPageTest::_createAdminuser" is not
| | in lowerCamel format
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/tests/src/Browser/FrontPageTest.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
20 | WARNING | Property name "$_testCustomPath" should not be prefixed with
| | an underscore to indicate visibility
20 | ERROR | Class property $_testCustomPath should use lowerCamel naming
| | without underscores
27 | WARNING | Property name "$_testDefaultPath" should not be prefixed with
| | an underscore to indicate visibility
27 | ERROR | Class property $_testDefaultPath should use lowerCamel naming
| | without underscores
163 | ERROR | Private method name "FrontPageTest::_testPageTypeTestTemplate"
| | is not in lowerCamel format
185 | ERROR | Private method name "FrontPageTest::_createAdminuser" is not
| | in lowerCamel format
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/src/Helper/DrupalSheetJsHelper.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
14 | ERROR | Class property $dest_table_id should use lowerCamel naming
| | without underscores
21 | ERROR | Class property $submit_element_id should use lowerCamel naming
| | without underscores
28 | ERROR | Class property $submit_full_element_id should use lowerCamel
| | naming without underscores
35 | ERROR | Class property $current_file_name should use lowerCamel naming
| | without underscores
42 | ERROR | Class property $full_data_file_name should use lowerCamel naming
| | without underscores
49 | ERROR | Class property $export_type should use lowerCamel naming without
| | underscores
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/drupal_sheetjs/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
191 | ERROR | Private method name "SettingsForm::_cssIdValidator" is not in
| | lowerCamel format
207 | ERROR | Private method name "SettingsForm::_getDestTableId" is not in
| | lowerCamel format
214 | ERROR | Private method name "SettingsForm::_getSubmitElementId" is not
| | in lowerCamel format
221 | ERROR | Private method name "SettingsForm::_getSubmitFullElementId" is
| | not in lowerCamel format
228 | ERROR | Private method name "SettingsForm::_getCurrentFileName" is not
| | in lowerCamel format
235 | ERROR | Private method name "SettingsForm::_getFullDataFileName" is not
| | in lowerCamel format
--------------------------------------------------------------------------------

FILE: ...w/html/vb/d_cont/drupal_sheetjs/src/Controller/DrupalSheetjsController.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
34 | ERROR | Public method name "DrupalSheetjsController::test_custom" is not
| | in lowerCamel format
49 | ERROR | Private method name
| | "DrupalSheetjsController::_getDrupalSheetjsConfigDataService" is
| | not in lowerCamel format
--------------------------------------------------------------------------------

FILE: .../html/vb/d_cont/drupal_sheetjs/src/Services/DrupalSheetjsConfigService.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
35 | ERROR | Private method name "DrupalSheetjsConfigService::_getDefaultData"
| | is not in lowerCamel format
63 | ERROR | Private method name "DrupalSheetjsConfigService::_getTestData" is
| | not in lowerCamel format
--------------------------------------------------------------------------------

Time: 144ms; Memory: 10MB

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    Satish_kumar

    Hii @urvashi_vora I have applied your patch.

    These are the steps I followed:

    1. Took clone from git version 1.x in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/drupal_sheetjs/

    3. Applied patch,
    again ran phpcs command and found errors.

    Needs work.

  • Comment over 1 year ago →
    🇮🇳India Shreya_98

    @Satish_kumar i am working on this issue. provide you the patch as soon as possible.

  • Comment over 1 year ago →
    🇮🇳India Shreya_98

    @Satish_kumar all the issues which related to method in which we have to provide correct format of methods in lowercamel case or issues related to class property will be solve by maintainer.

  • First commit to issue fork.
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇨🇳China vanchao0519

    Fixed

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024