Fix the issues reported by phpcs

Open on Drupal.org →

Created on 11 April 2023, about 1 year ago

Updated 10 October 2023, 9 months ago

Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/microcontent/microcontent.post_update.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/microcontent/tests/src/Kernel/MicroContentTranslationTest.php
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
64 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/microcontent/microcontent.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
54 | ERROR | [x] Expected 1 blank line after function; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/microcontent/src/EntityHandlers/MicrocontentViewBuilder.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

Time: 5.38 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/microcontent/

Proposed resolution

Above error/warnings need to be fixed.

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @samit.310@gmail.com
Issue was unassigned.
Status changed to Needs review about 1 year ago6:32am 11 April 2023
Comment about 1 year ago →
🇮🇳India samit.310@gmail.com
Issue fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 9 months ago
6 pass
Comment 9 months ago →
Satish_kumar
hii@samit .310@gmail.com

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 8.x.1 in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/microcontent/

3. Applied your patch and, again ran phpcs command

found errors.

4. Create a patch and fixed the errors.

Please Review.
Status changed to RTBC 9 months ago6:07am 28 September 2023
Comment 9 months ago →
🇮🇳India aayushDrupal
Hi Satish_kumar,
Your patch #3 has been successfully applied without any remaining errors by Phpcs. I have attached a screenshot for your reference. Please check.

Moving to RTBC.
Thanks
Comment 9 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks folks

Per my policy on phpcs issues - I don't grant credit to those who already have credits for a few PHPCS fixes.
Comment 9 months ago →
System Message

larowlan → committed 55bcbf1a on 8.x-1.x
Issue #3353350 by samit.310@gmail.com, Satish_kumar: Fix the issues...
Status changed to Fixed 9 months ago8:50pm 10 October 2023
Comment 9 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024