- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:32am 11 April 2023 - last update
about 1 year ago 6 pass Thanks for the patch, I have applied your patch and ran successfully.
These are the steps I followed:
1. Took clone from git version 8.x.1 in drupal 10.1.x
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/microcontent/
3. Applied your patch and, again ran phpcs command
found errors.
4. Create a patch and fixed the errors.
Please Review.
- Status changed to RTBC
about 1 year ago 6:07am 28 September 2023 - 🇮🇳India aayushDrupal
Hi Satish_kumar,
Your patch #3 has been successfully applied without any remaining errors by Phpcs. I have attached a screenshot for your reference. Please check.Moving to RTBC.
Thanks - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks folks
Per my policy on phpcs issues - I don't grant credit to those who already have credits for a few PHPCS fixes.
-
larowlan →
committed 55bcbf1a on 8.x-1.x
Issue #3353350 by samit.310@gmail.com, Satish_kumar: Fix the issues...
-
larowlan →
committed 55bcbf1a on 8.x-1.x
- Status changed to Fixed
about 1 year ago 8:50pm 10 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.