Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 7 July 2023, over 1 year ago
Updated 26 September 2023, about 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/blocktabs_jquery_ui/blocktabs_jquery_ui.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: .../d_cont/blocktabs_jquery_ui/components/tabs-ui-default/tabs-ui-default.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | [ ] Class definition is empty
2 | ERROR | [x] Expected 1 newline at end of file; 2 found
3 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ml/vb/d_cont/blocktabs_jquery_ui/components/accordion-ui/accordion-ui.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...tml/vb/d_cont/blocktabs_jquery_ui/components/accordion-ui/accordion-ui.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
1 | ERROR | [ ] Class definition is empty
2 | ERROR | [x] Expected 1 newline at end of file; 2 found
3 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...cont/blocktabs_jquery_ui/components/tabs-ui-vertical/tabs-ui-vertical.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ..._cont/blocktabs_jquery_ui/components/tabs-ui-vertical/tabs-ui-vertical.css
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
28 | ERROR | [x] Expected 1 newline at end of file; 2 found
29 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 44ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig blocktabs_jquery_ui/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

2.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    Satish_kumar

    Hii, @urvashi_vora I have Review your patch.

    These are the steps I followed:

    1. Took clone from git version 2.0.x in drupal 10.1.x

    2. Applied patch and ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
    d,yml,twig modules/contrib/blocktabs_jquery_ui/

    3. Applied your patch and, again ran phpcs command

    found errors.

    Needs work.

  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India ashutosh ahirwal India

    Hi, I have fixed the remaining issue and providing updated patch for it.

  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India aayushDrupal

    Hi Ashutosh Ahirwal,
    I have applied your Patch #3 and did not encounter any PHPCS errors. I have attached a screenshot for your reference.

    Moving to RTBC for now.

    Thank you

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024