Fix the issues reported by phpcs

Open on Drupal.org →

Created on 5 July 2023, over 1 year ago

Updated 30 April 2024, 7 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/routing_on_exception/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 86 characters
4 | WARNING | Line exceeds 80 characters; contains 84 characters
7 | WARNING | Line exceeds 80 characters; contains 85 characters
8 | WARNING | Line exceeds 80 characters; contains 88 characters
13 | WARNING | Line exceeds 80 characters; contains 87 characters
14 | WARNING | Line exceeds 80 characters; contains 89 characters
55 | WARNING | Line exceeds 80 characters; contains 84 characters
58 | WARNING | Line exceeds 80 characters; contains 83 characters
63 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------

FILE: .../vb/d_cont/routing_on_exception/src/RoutingOnExceptionManagerInterface.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
9 | ERROR | [x] Missing interface doc comment
17 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
19 | ERROR | [x] Expected 1 blank line after function; 0 found
20 | ERROR | [x] The closing brace for the interface must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../d_cont/routing_on_exception/src/RoutingOnExceptionDefinitionException.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
5 | ERROR | [x] Missing class doc comment
6 | ERROR | [x] Opening brace should be on the same line as the declaration
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../routing_on_exception/src/EventSubscriber/RoutingOnExceptionSubscriber.php
--------------------------------------------------------------------------------
FOUND 21 ERRORS AND 1 WARNING AFFECTING 13 LINES
--------------------------------------------------------------------------------
20 | ERROR | [x] Opening brace should be on the same line as the declaration
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] The open comment tag must be the only content on the line
21 | ERROR | [ ] Missing short description in doc comment
21 | ERROR | [x] Data types in @var tags need to be fully namespaced
21 | ERROR | [x] Expected "RoutingOnExceptionManagerInterface" but found
| | "RoutingOnExceptionManagerInterface " for @var tag in
| | member variable comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] The open comment tag must be the only content on the line
24 | ERROR | [ ] Missing short description in doc comment
24 | ERROR | [x] Data types in @var tags need to be fully namespaced
24 | ERROR | [x] Expected "LoggerChannelInterface" but found
| | "LoggerChannelInterface " for @var tag in member variable
| | comment
27 | ERROR | [x] Visibility must be declared on method "__construct"
27 | ERROR | [x] Missing function doc comment
35 | ERROR | [x] Missing function doc comment
36 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Missing function doc comment
42 | ERROR | [x] Opening brace should be on the same line as the declaration
52 | ERROR | [x] Case breaking statements must be followed by a single blank
| | line
65 | ERROR | [x] Opening brace should be on the same line as the declaration
67 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
69 | ERROR | [ ] The array declaration extends to column 90 (the limit is
| | 80). The array content should be split up over multiple
| | lines
70 | ERROR | [ ] The array declaration extends to column 83 (the limit is
| | 80). The array content should be split up over multiple
| | lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: .../www/html/vb/d_cont/routing_on_exception/src/RoutingOnExceptionManager.php
--------------------------------------------------------------------------------
FOUND 38 ERRORS AND 7 WARNINGS AFFECTING 45 LINES
--------------------------------------------------------------------------------
8 | ERROR | [ ] Missing short description in doc comment
9 | WARNING | [x] '@TODO: Make this use plugins for different tests /
| | actions.' should match the format '@todo Fix problem X
| | here.'
13 | ERROR | [x] Missing function doc comment
31 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
43 | ERROR | [x] Missing function doc comment
44 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
51 | ERROR | [ ] The array declaration extends to column 82 (the limit is
| | 80). The array content should be split up over multiple
| | lines
78 | ERROR | [ ] The array declaration extends to column 104 (the limit is
| | 80). The array content should be split up over multiple
| | lines
85 | ERROR | [x] Missing function doc comment
86 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
96 | ERROR | [ ] The array declaration extends to column 84 (the limit is
| | 80). The array content should be split up over multiple
| | lines
103 | ERROR | [ ] The array declaration extends to column 81 (the limit is
| | 80). The array content should be split up over multiple
| | lines
125 | ERROR | [ ] The array declaration extends to column 110 (the limit is
| | 80). The array content should be split up over multiple
| | lines
128 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
133 | ERROR | [ ] The array declaration extends to column 110 (the limit is
| | 80). The array content should be split up over multiple
| | lines
136 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
139 | ERROR | [ ] The array declaration extends to column 102 (the limit is
| | 80). The array content should be split up over multiple
| | lines
148 | ERROR | [x] Missing function doc comment
149 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
153 | ERROR | [x] Missing function doc comment
154 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
158 | ERROR | [x] Missing function doc comment
159 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
163 | ERROR | [x] Missing function doc comment
164 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
168 | ERROR | [x] Missing function doc comment
169 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
170 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE"
| | but found "false"
173 | ERROR | [x] Missing function doc comment
175 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
191 | ERROR | [x] Missing function doc comment
192 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
193 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
195 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"
| | but found "true"
197 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
199 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
205 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
208 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
211 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
217 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
218 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"
| | but found "true"
220 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE"
| | but found "false"
221 | ERROR | [x] Expected 1 blank line after function; 0 found
222 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 162ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig routing_on_exception/

Remaining tasks

Patch review

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @urvashi_vora
Status changed to RTBC about 1 year ago11:44am 26 September 2023
Comment about 1 year ago →
Satish_kumar
Hii, @urvashi_vora ,

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/routing_on_exception/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving this to RTBC.

Comment 7 months ago →

a98cdfa8 committed on 1.0.x

Issue #3372405 by urvashi_vora, Satish_kumar: Fix the issues reported by...

Status changed to Fixed 7 months ago9:09pm 16 April 2024
Comment 7 months ago →
🇬🇧United Kingdom jamsilver West Midlands, UK
Committed and pushed to 1.0.x. Thank you for your contribution!
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024