Committed and pushed to 1.0.x. Thank you for your contribution!
Looks like this was fixed last week: https://git.drupalcode.org/project/formstack/-/commit/1896f199a709fb633a...
Raised a follow up issue, requesting we store this node reference as a UUID rather than an ID to make it simpler to script the set-up and deployment of this module: https://www.drupal.org/project/cookiebot/issues/3414375 ✨ Store node reference via UUID rather than ID to aid multi-environment deployments Needs review
I've raised a Merge Request
jamsilver → created an issue.
Oh I've realised that the module maintainer fixed this issue directly on 2.x last month.
Rather than apply a patch, install this exact commit to get the better fix. For example:
php composer.phar require drupal/flexible_views:dev-2.x#a669a7
This patch does not work for me. It simply causes a Fatal Error when $fields tries to be used further down the method.
For me, the notice is associated with loading an attached Data Export display, since the style plugin is different. In this case the exposed form is irrelevant. Suggest an early return.
Merge Request raised.
jamsilver → created an issue.
Merge request raised.
jamsilver → created an issue.
I've raised a Merge Request with a first pass here.
In theory to remain backwards compatible we'd need to write an update hook that updates all user roles that have "access content" to add the new "administer views_save_search_filter searches" perm. This is not presently included.
Alternatively could bump the major version.
jamsilver → created an issue.
jamsilver → made their first commit to this issue’s fork.
I've raised a MR that adds Move to Top / Move to Bottom buttons. It's not the full drag & drop solution, but it's not nothing either.
jamsilver → created an issue.
jamsilver → created an issue.
See attached patch.
jamsilver → created an issue.
Looks like https://www.drupal.org/project/content_roles → may be doing a very similar thing. If so, perhaps we should recommend am upgrade path to that module for D9?
This patch worked perfectly to solve the problem for ckeditor_resize 1.3.0
I had a situation with a unit tests that failed because it executed the same migration twice in the same page request. It wasn't enough for migrate_tools_sync state to be reset in the constructor.
I've created a Merge Request that adds the following changes to the patch in 22 (interdiff attached):
- Reset migrate_tools_sync at the point of scanning through source rows to collect the IDs. This fixes my unit test
- Factor that bit of code to a new method for readability.
I've also raised this as a Merge Request, rather than as a patch, since that is the workflow in place on this ticket originally. I raised a new one because things seem to have moved along quite a lot since the original was raised.
Tests fail, but the first error I'm seeing looks unrelated to my change. Is there a problem with the tests at the moment?
jamsilver → made their first commit to this issue’s fork.
This has been working for us in a production codebase for a couple years.