Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 10 July 2023, over 1 year ago
Updated 3 October 2023, about 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/xmap_hub/xmap_hub.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/xmap_hub/xmap_hub.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Missing function doc comment
13 | WARNING | [x] A comma should follow the last multiline array item. Found:
| | ]
16 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/xmap_hub/src/Plugin/Block/XmapHub.php
--------------------------------------------------------------------------------
FOUND 74 ERRORS AND 3 WARNINGS AFFECTING 37 LINES
--------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
24 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
25 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
27 | ERROR | [x] Short array syntax must be used to define arrays
39 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
41 | ERROR | [x] There should be no white space after an opening "("
42 | ERROR | [x] There should be no white space after an opening "("
43 | ERROR | [x] Expected 1 space after IF keyword; 0 found
43 | ERROR | [x] Inline control structures are not allowed
43 | ERROR | [x] There should be no white space after an opening "("
43 | ERROR | [x] There should be no white space before a closing ")"
43 | ERROR | [x] There should be no white space after an opening "("
43 | ERROR | [x] There should be no white space before a closing ")"
44 | ERROR | [x] Expected 1 space after IF keyword; 0 found
44 | ERROR | [x] Inline control structures are not allowed
44 | ERROR | [x] There should be no white space after an opening "("
44 | ERROR | [x] There should be no white space before a closing ")"
44 | ERROR | [x] There should be no white space after an opening "("
44 | ERROR | [x] There should be no white space before a closing ")"
45 | ERROR | [x] Expected 1 space after IF keyword; 0 found
45 | ERROR | [x] Inline control structures are not allowed
45 | ERROR | [x] There should be no white space after an opening "("
45 | ERROR | [x] There should be no white space before a closing ")"
45 | ERROR | [x] There should be no white space after an opening "("
45 | ERROR | [x] There should be no white space before a closing ")"
46 | ERROR | [x] Expected 1 space after IF keyword; 0 found
46 | ERROR | [x] Inline control structures are not allowed
46 | ERROR | [x] There should be no white space after an opening "("
46 | ERROR | [x] There should be no white space before a closing ")"
46 | ERROR | [x] There should be no white space after an opening "("
46 | ERROR | [x] There should be no white space before a closing ")"
47 | ERROR | [x] Expected 1 space after IF keyword; 0 found
47 | ERROR | [x] Inline control structures are not allowed
47 | ERROR | [x] There should be no white space after an opening "("
47 | ERROR | [x] There should be no white space before a closing ")"
47 | ERROR | [x] There should be no white space after an opening "("
47 | ERROR | [x] There should be no white space before a closing ")"
48 | ERROR | [x] Expected 1 space after IF keyword; 0 found
48 | ERROR | [x] Inline control structures are not allowed
48 | ERROR | [x] There should be no white space after an opening "("
48 | ERROR | [x] There should be no white space before a closing ")"
48 | ERROR | [x] There should be no white space after an opening "("
48 | ERROR | [x] There should be no white space before a closing ")"
49 | ERROR | [x] Expected 1 space after IF keyword; 0 found
49 | ERROR | [x] Inline control structures are not allowed
49 | ERROR | [x] There should be no white space after an opening "("
49 | ERROR | [x] There should be no white space before a closing ")"
49 | ERROR | [x] There should be no white space after an opening "("
49 | ERROR | [x] There should be no white space before a closing ")"
50 | ERROR | [x] Expected 1 space after IF keyword; 0 found
50 | ERROR | [x] Inline control structures are not allowed
50 | ERROR | [x] There should be no white space after an opening "("
50 | ERROR | [x] There should be no white space before a closing ")"
50 | ERROR | [x] There should be no white space after an opening "("
50 | ERROR | [x] There should be no white space before a closing ")"
52 | ERROR | [x] Space before opening parenthesis of function call
| | prohibited
57 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $url
61 | ERROR | [x] Missing function doc comment
62 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
64 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
68 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
70 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
| | but found "null"
76 | ERROR | [x] Missing function doc comment
77 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
92 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
107 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 2 empty lines
136 | ERROR | [x] Functions must not contain multiple empty lines in a row;
| | found 5 empty lines
138 | ERROR | [ ] More than 2 empty lines are not allowed
139 | ERROR | [ ] More than 2 empty lines are not allowed
140 | ERROR | [ ] More than 2 empty lines are not allowed
155 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
172 | ERROR | [x] Opening brace should be on the same line as the
| | declaration
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 74 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 78ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig xmap_hub/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    Satish_kumar

    Hello, @urvashi_vora thanks for the patch

    These are the steps I followed:

    1. Took clone from git version 1.0.x in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/xmap_hub/

    3. Applied your patch and, again ran phpcs command

    found no errors.

    Moving to RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024