Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 11 July 2023, over 1 year ago
Updated 26 September 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/mailersend/mailersend.links.menu.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/mailersend/mailersend.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/mailersend/src/Form/MailerSendSettingsForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
53 | ERROR | [ ] The array declaration extends to column 255 (the limit is
| | 80). The array content should be split up over multiple
| | lines
156 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/mailersend/src/Plugin/Mail/MailerSendMail.php
---------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
26 | ERROR | [x] Missing class doc comment
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/mailersend/mailersend.permissions.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
3 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 232ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig mailersend/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    Satish_kumar

    Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

    These are the steps I followed:

    1. Took clone from git version 1.0.x in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/mailersend/

    3. Applied your patch and, again ran phpcs command

    found errors.

    Needs work.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India sakthi_dev

    Please review.

  • Comment over 1 year ago →
    🇵🇭Philippines clarkssquared

    Hi sakthi_dev

    I applied your patch #3 to the MailerSend module version1.0.x-dev and I confirmed that all PHPCS issues were fixed, this is RTBC +1 for me I will retain its status for others to review before the issue will transition to RTBC.

    Please look at the screenshot I attached for your reference.

    Thank you

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India aayushDrupal
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024