Fix validate pipeline

Hii @sidharth_soman I have applied your patch.

These are the steps I followed:

1. Took clone from git version 2.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/devel_debug_log/

3. applied patch found same errors.

Needs work.

Please review patch.

Hi @chaitanyadessai,

I have applied your patch and ran successfully.

Ran the phpcs command, found no errors, attaching screenshot for same.

Moving to RTBC.

Please turn this into a MR instead.

Please review MR.

@chaitanyadessai: CSpell, eslint and phpstan are still unhappy: https://git.drupalcode.org/project/devel_debug_log/-/pipelines/272194

Can you also fix these please? Then we're done here! :)

chaitanyadessai → closed merge request !8

@ankitv18 thank you! Of course anyone can do it.

The changes committed in #10 actually broke the ddl() function, since it was renamed to devel_debug_log_ddl(). Either this should be reverted, or the project page and README should be updated.

@mandclu ,
I believe MR!9 changes will fix the concern.

ankitv18 → changed the visibility of the branch 3373694-fix-the-issues to hidden.

Thanks @mandclu and SORRY I didn't see that. Should not have happened!

I'll revert that, because of course ddl() should be kept as alternative to dsm(), kint() etc!

No offend to maintainers, but this is a perfect example where the ever growing number of (probably mostly automated) "code style" fixings get worse by breaking an essential function of the module. I am a module maintainer myself and imho it's like kind of spam nowadays how these issues are created at mass without having real value in improving the module.

And specifically the rule "All functions defined in a module file must be prefixed with the module's name" has potential for trouble causing BC breaks. This should not be lightly used in such automated fixes.

And once again, full respect and thanks to maintainers of devel_debug_log, I use it very often and it is very helpful.

Automatically closed - issue fixed for 2 weeks with no activity.