- Issue created by @Harish1688
- Status changed to Needs review
over 1 year ago 1:38pm 31 July 2023 - last update
over 1 year ago 29,911 pass - 🇮🇳India Harish1688 India
created a patch 3377198-2.patch for the issue.
Need review.Testing Steps:
1. set Drupal with 11.x and enable claro as backend theme.
2. enable the forced color mode active in browser, and check the issue in toolbar.After patch:
Note: In pcss file hex color code are used however use the follow the same not used variables.
- last update
over 1 year ago 29,911 pass - 🇮🇳India Harish1688 India
wrong patch commit by mistake in last patch #2, commit the correct one 3378190-2.patch,
Needs Review Hi @Harish1688
Verified your #3 patch on Drupal 9.5.8 and Drupal 11.x, the issue is fixed now. Added after and before screenshots.- Status changed to RTBC
over 1 year ago 11:19am 1 August 2023 @Harish1688, I applied your patch in Drupal 11.x. It is successfully applied. The border issue is now resolved. Attaching screenshot for the same. Moving to RTBC.
- Status changed to Needs work
over 1 year ago 3:41pm 1 August 2023 - 🇫🇮Finland lauriii Finland
-
+++ b/core/themes/claro/css/theme/toolbar.theme.css @@ -175,3 +175,12 @@ + .toolbar-horizontal .toolbar .toolbar-toggle-orientation button.toolbar-icon {
Can we remove the tag (
button
) from the selector? We usually try to avoid introducing additional dependencies on things like the tag when possible. -
+++ b/core/themes/claro/css/theme/toolbar.theme.css @@ -175,3 +175,12 @@ + border-top: 1px solid #aaa; ... + border-bottom: 1px solid #aaa;
Nit: We could set the borders as transparent
-
- 🇮🇳India _utsavsharma
Tried to address the pointers in #6.
Attaching patch as well as interdiff. - last update
over 1 year ago 29,946 pass - Status changed to RTBC
over 1 year ago 6:31am 2 August 2023 Hi@_utsavsharma, I have review your patch, applied successfully. It works fine and also button tag is removed as suggested by @lauriii attaching screenshot for the same.
moving it to RTBC.- last update
over 1 year ago 29,946 pass - last update
over 1 year ago 29,952 pass, 2 fail The last submitted patch, 3: 3378190-2.patch, failed testing. View results →
- last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,955 pass, 2 fail The last submitted patch, 3: 3378190-2.patch, failed testing. View results →
- Status changed to Fixed
over 1 year ago 1:45pm 15 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.