Fix the issues reported by phpcs

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/login_history/login_history.module ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------- 8 | WARNING | [x] Unused use statement 88 | WARNING | [ ] Unused variable $query. ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/login_history/src/Form/AdminSettingsForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- Time: 418ms; Memory: 10MB

Comments & Activities

Issue created by @paraderojether
Issue was unassigned.
Status changed to Needs review over 1 year ago2:19am 31 May 2023
Comment over 1 year ago →
🇵🇭Philippines paraderojether
Created a patch to fix the issues reported by phpcs.

Please review.
Thank You.
Status changed to RTBC over 1 year ago6:59am 21 September 2023
Comment over 1 year ago →
Satish_kumar
Hii, @paraderojether,

Thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 2.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/login_history/

3. Applied your patch and, again ran phpcs command

found no errors.

Moving to RTBC.
Comment about 1 year ago →
System Message

paraderojether → authored f292326d on 2.x
Issue #3363707 by paraderojether, Satish_kumar, jcnventura: Fix the...
Status changed to Fixed about 1 year ago10:44pm 18 October 2023
Comment about 1 year ago →
🇵🇹Portugal jcnventura
Thanks for this
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Comments & Activities