- Issue created by @Nitin shrivastava
Tanushree Gupta โ made their first commit to this issueโs fork.
- Merge request !1regions-added: Replaced the header region with the navigation. โ (Open) created by Tanushree Gupta
- Status changed to Needs review
8 months ago 8:09am 13 March 2024 - ๐ฎ๐ณIndia aayushDrupal
Hi Tanushree Gupta,
I have reviewed the layout for the "food" theme, in my observation header is replaced with navigation.
Screenshot attached below for reference.thanks.
- Status changed to Needs work
8 months ago 6:28am 10 April 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
Theme also need default config installation so that website will not look broken.
- Assigned to punit pradhan
- ๐ฎ๐ณIndia punit pradhan
have added config/optional
and added a header region as it was missing in the twig.can you verify the changes @ravi kant
- Issue was unassigned.
- Status changed to Needs review
7 months ago 7:41am 23 April 2024 - Status changed to Needs work
7 months ago 9:01am 23 April 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@punit pradhan
The issue also not fixed.
Because main navigation is not displaying in region according design.
If someone installing theme and making it as default then all basic block need to be in related regions. - ๐ฎ๐ณIndia punit pradhan
after changing config/optional/block.block.food_main_menu.yml
langcode: en status: true dependencies: config: - system.menu.main module: - system theme: - food id: food_main_menu theme: food region: Navigation weight: -8 provider: null plugin: 'system_menu_block:main' settings: id: 'system_menu_block:main' label: 'Main navigation' provider: system label_display: '0' level: 1 depth: 1 expand_all_items: false visibility: { }
in config file block.block.food_main_menu.yml I am getting this
uuid: 913f7745-d5b5-4625-bacf-ac3d9dc19221 langcode: en status: true dependencies: config: - system.menu.main module: - system theme: - food _core: default_config_hash: sOBfLFUB4t3yuAG5cmsbqVnN31761mx5SUHgrjS3Lpk id: food_main_menu theme: food region: Navigation weight: -4 provider: null plugin: 'system_menu_block:main' settings: id: 'system_menu_block:main' label: 'Main navigation' label_display: '0' provider: system level: 1 depth: 9 expand_all_items: false visibility: { }
does it look correct to you.
- ๐ฎ๐ณIndia ravi kant Jaipur
Yes @punit pradhan, but only for add 'region name". Do not add
default_config_hash: sOBfLFUB4t3yuAG5cmsbqVnN31761mx5SUHgrjS3Lpk
Also i have made changes for main-menu. You may do for other default block configs.
- ๐ฎ๐ณIndia punit pradhan
@ravi kant can you share the file so I can have a look at it in your latest Commit I am not able to see anything.
- ๐ฎ๐ณIndia ravi kant Jaipur
@punit pradhan
Thank you for review.
I have added config file of main-menu now. - ๐ฎ๐ณIndia punit pradhan
can you review the remaining files and tell me which files I need to change now @ravi kant
- ๐ฎ๐ณIndia ravi kant Jaipur
@punit pradhan
It depends on theme Design so we can assume according theme Design or asking to website maintainer. - ๐ฎ๐ณIndia punit pradhan
@ravi kant I have checked the files and I have previously arranged the region according to our theme so if the maintainer wants any specific change we can do that after his review Let's change its state.
- Status changed to RTBC
7 months ago 12:59pm 26 April 2024 - Status changed to Needs review
7 months ago 6:43am 30 April 2024