🇮🇳India @punit pradhan

after checking everything no errors are been showing

this is the image of the front page

The slider is working fine.

so I am moving the state.

punit pradhan → changed the visibility of the branch 3441438-theme-settings to active.

punit pradhan → changed the visibility of the branch 3441438-theme-settings to hidden.

now for the other setting

as you can see slider is not showing on any page except the home page.

so I have added the functionality of slide so now we have more slider settings to include an option like:-

1) show slider only on the home page
2) show slider on all pages except the home page
3) show on all page

that allows us to control where the slider appears.

and results are below
this is my homepage

any random page

punit pradhan → changed the visibility of the branch 1.0.x to hidden.

punit pradhan → changed the visibility of the branch 1.0.x to active.

punit pradhan → changed the visibility of the branch 1.0.x to hidden.

ok i am working on it.

can you attach some pictures and if possible a video to reproduce the issue. @luke.stewart

@ravi kant I have checked the files and I have previously arranged the region according to our theme so if the maintainer wants any specific change we can do that after his review Let's change its state.

can you review the remaining files and tell me which files I need to change now @ravi kant

@ravi kant can you share the file so I can have a look at it in your latest Commit I am not able to see anything.

after changing config/optional/block.block.food_main_menu.yml

langcode: en
status: true
dependencies:
  config:
    - system.menu.main
  module:
    - system
  theme:
    - food
id: food_main_menu
theme: food
region: Navigation
weight: -8
provider: null
plugin: 'system_menu_block:main'
settings:
  id: 'system_menu_block:main'
  label: 'Main navigation'
  provider: system
  label_display: '0'
  level: 1
  depth: 1
  expand_all_items: false
visibility: {  }

in config file block.block.food_main_menu.yml I am getting this

uuid: 913f7745-d5b5-4625-bacf-ac3d9dc19221
langcode: en
status: true
dependencies:
  config:
    - system.menu.main
  module:
    - system
  theme:
    - food
_core:
  default_config_hash: sOBfLFUB4t3yuAG5cmsbqVnN31761mx5SUHgrjS3Lpk
id: food_main_menu
theme: food
region: Navigation
weight: -4
provider: null
plugin: 'system_menu_block:main'
settings:
  id: 'system_menu_block:main'
  label: 'Main navigation'
  label_display: '0'
  provider: system
  level: 1
  depth: 9
  expand_all_items: false
visibility: {  }

does it look correct to you.

have added config/optional

and added a header region as it was missing in the twig.

can you verify the changes @ravi kant

ok ill look into this.

punit pradhan → changed the visibility of the branch 3440376-links-inside-heading to hidden.

can you explain more about this issue in detail @luke.stewart

punit pradhan → made their first commit to this issue’s fork.

after using this https://www.drupal.org/project/dxpr_theme/releases/6.x-dev →

need to work on fixing some issues in code.

@ravi kant
have updated the pr now added default values to social media icons.

The overflow issue was caused by .shortcut-action__message. After applying the following CSS to hide it, everything is now functioning properly:

.shortcut-action__message {
  display: none;
}

there is still overflow issue after my test even after using the patch file

can you use this and let me know if this is working on your system

let me look into it.

ill look into it.

punit pradhan → made their first commit to this issue’s fork.

i have a suggestion we can modify menu--main.html.twig

and i have an example

<div class="menu-wrapper">
  <ul data-block="header" class="main-menu">
    {% for item in items %}
      <li class="main-menu-level-0">
        {% if item.url %}
          {% if item.url.isRouted() and item.url.getRouteName() != '<nolink>' %}
            <a href="{{ item.url }}" {{ item.attributes.addClass(["main-level-0", "item"]) }}>{{ item.title }}</a>
          {% else %}
            <div class="mobile-main-menu-icon-back">
              <i class="lni lni-arrow-left"></i>
            </div>
             <span {{ item.attributes.addClass(["main-level-0", "item"]) }}>{{ item.title }}</span>
            <div class="mobile-main-menu-icon">
              <i class="lni lni-chevron-right"></i>
            </div>
          {% endif %}
        {% else %}
           <span {{ item.attributes.addClass(["main-level-0", "item"]) }}>{{ item.title }}</span>
        {% endif %}
        {% if item.below %}
          <div class="main-menu-level-1-wrapper">
            <ul class="main-menu-level-1">
              {% for subItem in item.below %}
                <li class="main-level-1">
                  {% if subItem.url %}
                    {% if subItem.url.isRouted() and subItem.url.getRouteName() != '<nolink>' %}
                      <div class="main-menu-links">
                        <a href="{{ subItem.url }}" {{ subItem.attributes.addClass(["main-level-1", "main-menu-links__item"]) }}>{{ subItem.title }}</a>
                      </div>
                    {% else %}
                      <span {{ subItem.attributes.addClass(["main-level-1", "item"]) }}>{{ subItem.title }}</span>
                    {% endif %}
                  {% else %}
                    <span {{ subItem.attributes.addClass(["main-level-1", "item"]) }}>{{ subItem.title }}</span>
                  {% endif %}
                  {% if subItem.below %}
                    <ul class="main-menu-level-2">
                      {% for subSubItem in subItem.below %}
                        <li class="main-level-2">
                          {% if subSubItem.url %}
                            {% if subSubItem.url.isRouted() and subSubItem.url.getRouteName() != '<nolink>' %}
                              <div class="main-menu-links">
                                <a href="{{ subSubItem.url }}" {{ subItem.attributes.addClass(["main-level-2", "main-menu-links__item"]) }}>{{ subSubItem.title }}</a>
                              </div>
                            {% else %}
                              <span {{ subItem.attributes.addClass(["main-level-2", "item"]) }}>{{ subSubItem.title }}</span>
                            {% endif %}
                          {% else %}
                            <span {{ subItem.attributes.addClass(["main-level-2", "item"]) }}>{{ subSubItem.title }}</span>
                          {% endif %}
                        </li>
                      {% endfor %}
                    </ul>
                  {% endif %}
                </li>
              {% endfor %}
            </ul>
          </div>
        {% endif %}
      </li>
    {% endfor %}
  </ul>
</div>

change class name to bootstrap name.
so this twig file addresses 2 problems it url has so it will put it in span and if it has a link so it will put it in a tag. doing so it wont brake the site.

punit pradhan → created an issue.

please review.

punit pradhan → made their first commit to this issue’s fork.

punit pradhan → made their first commit to this issue’s fork.

Could you please provide me the credits for this as I have put in some effort to make the module compatible.
Thank you @arsibux

ok ill look into it

ill do it for you so you can see the diffrence

punit pradhan → created an issue.

you can do this with theme