Search Block submit button Isssue

bh-shubh → made their first commit to this issue’s fork.

ok ill look into it

sourojeetpaul → closed merge request !69

sourojeetpaul → closed merge request !68

sourojeetpaul → reopened merge request !68

Looking at this change

https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/68/...

$barrio_path_images: "../../contrib/bootstrap_barrio/images/" !default;

:root,
[data-bs-theme=light] {
  --bb-primary-dark: #0c63e3;
  --bb-primary-text: #212529;
  --bb-secondary-dark: #5a6168;
  --bb-h1-color: #212529;
  --bb-h2-color: #212529;
  --bb-h3-color: #212529;
}

[data-bs-theme=dark] {
  color-scheme: dark;
  --bb-primary-text: #dee2e6;
  --bb-h1-color: #dee2e6;
  --bb-h2-color: #dee2e6;
  --bb-h3-color: #dee2e6;
}

Looks wrong on quite a few levels:

1. if you look at bootstrap these items are defined in _root.scss. Probably the same should apply here.

e.g.

:root,
[data-bs-theme="light"] {
  // Note: Custom variable values only support SassScript inside `#{}`.

  // Colors
  //
  // Generate palettes for full colors, grays, and theme colors.

  @each $color, $value in $colors {
    --#{$prefix}#{$color}: #{$value};
  }

  @each $color, $value in $grays {
    --#{$prefix}gray-#{$color}: #{$value};
  }

https://github.com/twbs/bootstrap/blob/main/scss/_root.scss#L1C1-L15C4

2. As mentioned here:

you have

$barrio_path_images: "../../contrib/bootstrap_barrio/images/" !default;

If accessing in theme created with bootstrap_sass this path in /web/themes/custom/my_barrio_subtheme/scss incorrect as we really want is the relative path? To get this to work with bootstrap_sass and barrio subtheme created with bootstrap_sass

e.g. $barrio_path_images: "../images/";.

3. hardcoding variable should be avoided. e.g.

--bb-primary-dark

Should probably also be

--#{$prefix}primary-dark

4. Probably the worst thing here is that this seem to introduce a new colour variable. There are so many variables already defined in bootstrap! My main issue here is that you are not working with the bootstrap colour system that is already extremely powerful albeit complex.