Links inside heading text color is hardcoded

Created on 12 April 2024, about 1 year ago
Updated 18 September 2024, 8 months ago

Problem/Motivation

A link in heading text has no visual indication that it exists.

Currently in css/base/typography.css there is the following css

h1 a,h2 a,h3 a,h4 a,h5 a,h6 a,.navbar-brand a,th a,.nav-tabs>li>a a{color:#333333}

This seems to come from:

https://git.drupalcode.org/project/dxpr_theme/-/blame/5.x/scss/base/typo...
and in 6.x it's similar
https://git.drupalcode.org/project/dxpr_theme/-/blob/6.x/scss/base/typog...

Would it not make more sense here perhaps not for navbar related links but for general heading links to have a contrasting color display before the on hover? Otherwise there is no visual indication that the link is a link.

Steps to reproduce

In a node create a heading (using hn) which has a link contained in it. This then does not show visually.

Proposed resolution

Happy to be told that headings shouldn't contain links. Which is the solution I will be pursuing in this case! But figured worth flagging here just in case.

๐Ÿ› Bug report
Status

RTBC

Version

6.0

Component

Code

Created by

๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand luke.stewart

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024