- Issue created by @luke.stewart
- ๐ฎ๐ณIndia punit pradhan
punit pradhan โ made their first commit to this issueโs fork.
- Assigned to punit pradhan
- ๐ฎ๐ณIndia punit pradhan
can you explain more about this issue in detail @luke.stewart
- ๐ฎ๐ณIndia punit pradhan
punit pradhan โ changed the visibility of the branch 3440376-links-inside-heading to hidden.
- ๐ณ๐ฟNew Zealand luke.stewart
Sorry rereading above I missed a step!
Hopefully the change to this problem/motivation now makes this clear.
- ๐ฎ๐ณIndia punit pradhan
can you attach some pictures and if possible a video to reproduce the issue. @luke.stewart
- First commit to issue fork.
- Merge request !3Issue #3440376: Links inside heading text color is hardcoded โ (Open) created by Esha_Kundu
- Issue was unassigned.
- Status changed to Needs review
6 months ago 5:55am 26 July 2024 Hello,
I found the issue exists in the current version, so I have raised the MR!3 for the same and updated the version.
I would be glad to hear from the maintainer if we need to create a separate field for color selection, so that heading containing links can be more customizable. For now I have implemented the color scheme similar to that of the other links (e.g. read more, add comments) present when a article/basic page is created.
I have added the ss for both without hover and with hover, before and after changes.
Please have a look.
Thanks- Status changed to RTBC
4 months ago 9:37am 18 September 2024 Hi @esha_kundu,
The patch that you've provided is resolving the issue, the MR also looks good to me. The approach that you've taken seems reasonable, but I'll also defer to the maintainer if he wants to have a separate field for that. But according to the current architecture it works for me, as we're now getting similar sort of hover colour on all kind of links. Hence moving the issue forward to RTBC++
Attaching before and after screenshots for quick reference.On a side note: The forked repo and the upstream seems to be out of sync, hence patch application will fail on composer installed version of the same. We need to sync them, in order to make the patch application successful on the project.