Fix the issues reported by phpcs

-              'title' => $this->t($button['title']),
-              'alt' => $this->t($button['title']),
+              'title' => $button['title'],
+              'alt' => $button['title'],

Since this issue is about coding standards, that is an off-topic change. Coding standards do not say that a variable cannot be passed to $this->t().

Also, before attaching further patches or creating MRs, it would be better to update the issue summary to make clearer what this patch is supposed to fix. follow the coding standards is quite a broad topic, which is different from fix what reported from phpcs; if the issue purpose is fixing what reported by phpcs, the issue summary needs to be explicit about that, and show the arguments passed to phpcs and what report phpcs outputs.

Hi @apaderno the changes those has been done in #2 resolving the phpcs issues and the $this->t(). does not seems to be off topic here, for making that clear i updated the issue summary, Reviewed the Patch looks good, Moving to NR, Revert back if needed.

Those changes are off-topic because that code could be correct.
phpcs is not able to understand if that code is correct; changing it just because phpcs says so is not correct. Before changing it, all the code used by the module should be checked.

I'm just confirming after applying the changes to the current module, i tested functionality, works alright, seems everything working as expected, therefore i moved it to NR as it does not break anything and also resolving the This->t() error reported by PHPCS, yes code could be correct already and its right that phpcs is unidentified it it is correct, but it looks alright even added with the patch.

+++ b/src/ShareEverywhereService.php
@@ -102,13 +102,13 @@ class ShareEverywhereService implements ShareEverywhereServiceInterface {
-      $build['#title'] = $this->t($config->get('title'));
+      $build['#title'] = $config->get('title');
...
-      'alt' => $this->t($config->get('share_icon.alt')),
+      'alt' => $config->get('share_icon.alt'),

These changes are right.
If this needs to be translatable, it needs to translate the configuration object, not passing the values through t(). See https://www.drupal.org/docs/multilingual-guide/translating-configuration →

please verify

Shreyas gowda → made their first commit to this issue’s fork.

Resolved the phpcs issues and commited it please review

Hi,
There are still PHPCS errors remaining, so I created a patch to fix all the remaining errors.
Thanks

I verified, it has the older code itself.