Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 10 July 2023, over 1 year ago
Updated 12 October 2023, about 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/drutopia_dev/drutopia_dev.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 27 WARNINGS AFFECTING 27 LINES
--------------------------------------------------------------------------------
6 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
10 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
11 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
12 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
13 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
14 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
15 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
16 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
17 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
18 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
19 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
20 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
21 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
22 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
23 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
24 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
25 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
26 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
27 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
28 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
29 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
30 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
31 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
32 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

FILE: ...cont/drutopia_dev/modules/drutopia_dev_findit/drutopia_dev_findit.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
10 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
11 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
12 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
13 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
14 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

Time: 75ms; Memory: 8MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig drutopia_dev/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

2.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India Ashutosh Ahirwal India

    I reviewed the provided patch.
    Patch get applied cleanly but there are some remaininig errors too.

    Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/drutopia_dev

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drutopia_dev/scripts/git-clone-origin-for-drutopia-projects.php
    ----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------
    3 | ERROR | [x] You must use "/**" style comments for a file comment
    5 | WARNING | [x] There must be no blank line following an inline comment
    5 | WARNING | [ ] There must be no blank line following an inline comment
    5 | ERROR | [ ] Comment indentation error, expected only 1 spaces
    5 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
    18 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
    18 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
    21 | ERROR | [x] Expected 1 newline at end of file; 3 found
    ----------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------

  • Assigned to Gautam_105@
  • Comment about 1 year ago →
    🇮🇳India Gautam_105@
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India Gautam_105@

    Hi Ashutosh Ahirwal,
    i have fixed issue and created patch for the same. Please reaview and see screenshot as well.

  • @gautam_105 opened merge request.
  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India aayushDrupal

    Hi,
    I have tested this issue locally and found no errors after applying the MR !1. Screenshot attached for reference.

    Moving to RTBC.
    Thanks.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024