Fix the issues reported by phpcs

Working on this.

I have raised an MR. The only errors remaining are those related to editing/filling out documentation comments.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.

Issue summary updated.

Hi,

I tried to applied the updated MR !3 but It seems that the MR didn't apply properly please refer to the snippet of the output in my terminal.

config_inspector git:(2.1.x) ✗ curl https://git.drupalcode.org/project/config_inspector/-/merge_requests/3.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12148    0 12148    0     0  21960      0 --:--:-- --:--:-- --:--:-- 22208
Checking patch src/Commands/InspectorCommands.php...
error: while searching for:
use Consolidation\AnnotatedCommand\CommandResult;
use Consolidation\OutputFormatters\StructuredData\MetadataInterface;
use Consolidation\OutputFormatters\StructuredData\RowsOfFields;
use Consolidation\OutputFormatters\StructuredData\UnstructuredListData;
use Drupal\config_inspector\ConfigInspectorManager;
use Drupal\config_inspector\ConfigSchemaValidatability;
use Drupal\Core\Config\StorageInterface;

error: patch failed: src/Commands/InspectorCommands.php:5
error: src/Commands/InspectorCommands.php: patch does not apply
Checking patch src/ConfigInspectorManager.php...
error: while searching for:

use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Config\Schema\Ignore;
use Drupal\Core\Config\Schema\Undefined;
use Drupal\Core\Config\TypedConfigManagerInterface;
use Drupal\Core\Config\Schema\Element;
use Drupal\Core\Config\Schema\SchemaCheckTrait;
use Drupal\Core\TypedData\PrimitiveInterface;
use Drupal\Core\TypedData\TraversableTypedDataInterface;
use Drupal\Core\TypedData\Type\BooleanInterface;
use Drupal\Core\TypedData\Type\DateTimeInterface;

error: patch failed: src/ConfigInspectorManager.php:4
error: src/ConfigInspectorManager.php: patch does not apply
Checking patch src/ConfigSchemaValidatability.php...
error: while searching for:

namespace Drupal\config_inspector;

final class ConfigSchemaValidatability {

  private $constraints = [];
  private $results = [];

  public function __construct(string $property_path, array $constraints) {
    $this->constraints[$property_path] = $constraints;
    $this->results[$property_path] = !empty($constraints);
  }

  /**
   * Merges other validatability; not necessarily of the same root property path.
   *
   * @param self $other
   *   Another validatability.

error: patch failed: src/ConfigSchemaValidatability.php:4
error: src/ConfigSchemaValidatability.php: patch does not apply
Checking patch src/Controller/ConfigInspectorController.php...
Hunk #3 succeeded at 198 (offset -1 lines).
Hunk #4 succeeded at 261 (offset -1 lines).
Hunk #5 succeeded at 388 (offset 5 lines).
➜  config_inspector git:(2.1.x) ✗ 

Rebased and fixed the remaining issues. Please review.

Hi,
Merge request !3 has resolved all the phpcs errors and everything seems fine to me . A screenshot is attached for reference.

Moving to RTBC.
Thanks

Thanks for doing this!

But … 4 tests are failing 😅 So, not quite working fine just yet.

Just merged 📌 Adopt GitLab CI Fixed , which will allow us to ensure to never regress against this again 😅

Thanks for the work here, everyone! Now reviewing…

I wanted to say "thanks", but it's hard to do so in this case, because this was done very poorly. It's literally breaking code, and it's removing parameters.

Therefore I'm not crediting:

1. @sidharth_soman (for breaking code by literally deleting it 🤯, thus me having to re-check everything — not what I'd expect from somebody with even the most basic experience)
2. @sakthi_dev (for not correctly realigning to 80 columns width and adding useless comments, thus me having to re-do all that)
3. @shiv_yadav (for not correctly realigning to 80 columns width and adding useless comments, thus me having to re-do all that)
4. @aayushmankotia (for RTBC'ing an issue at #14 that is literally no longer passing tests and uploading a useless screenshot of a patch applying)

To all of you: please read https://www.drupal.org/drupalorg/blog/ensuring-a-fair-drupal-contributio... → 🙏 This was clear gaming behavior.

I am crediting:

1. @apaderno for asking for clarifications in #5
2. @clarkssquared for correctly pointing out bugs in the MR at #10

Automatically closed - issue fixed for 2 weeks with no activity.