- ๐บ๐ธUnited States Darren Oh Lakeland, Florida
Darren Oh โ made their first commit to this issueโs fork.
- Merge request !6605Issue #3307519 by Darren Oh: Fix workspace link not redirecting to current page โ (Open) created by Darren Oh
- Status changed to Needs review
7 months ago 1:15am 15 February 2024 - ๐บ๐ธUnited States Darren Oh Lakeland, Florida
I'm not seeing any change in behavior with the Workspaces Extra module enabled. Merge request is ready for review.
The changes seem fine as mentioned in the proposed resolution. The workspace switcher is now redirecting to the current page.
Attached after screen recording.
Thanks
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi
Tested MR !6605 on Drupal version 11.x
Applied MR Successfully...Testing steps:
Install the workspaces module
Login as admin
Click on the "Configuration" link in the admin toolbar
Click the "Live" link in the top right of the toolbar to open the default workspace switcher
Click the "Stage" link and confirm the switch in the modal that opens
Apply the Patch and check for the sameTest Result:
The changes look as mentioned in the proposed resolution.
The workspace switcher is redirecting to the same page.Attaching videos for references
RTBC++Keeping in "Need review" for more reviews
- Status changed to Needs work
7 months ago 1:09am 17 February 2024 - ๐บ๐ธUnited States smustgrave
Thanks for reporting. Will need a failing test as a next step.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 3:00pm 19 April 2024 - ๐ท๐ดRomania amateescu
Adding the
url.path
cache context to every page would be a performance regression, and we can avoid it if we use a lazy builder instead for the workspace toolbar tab, just likeannouncements_feed
module does it.I wasted a lot of time trying to add test coverage, with no success: https://git.drupalcode.org/project/drupal/-/merge_requests/7605/commits . Adding coverage for this should be as easy as adding a few more
drupalGet()
calls inWorkspaceToolbarIntegrationTest::testWorkspaceSwitch()
, but our functional javascript test framework disagrees :/My proposal is to go with only manual testing here, otherwise the issue will be stalled for who knows how many years...
- Status changed to RTBC
5 months ago 5:39pm 19 April 2024 - Status changed to Needs review
5 months ago 10:12am 20 April 2024 - Status changed to RTBC
5 months ago 8:56am 22 April 2024 - Status changed to Fixed
5 months ago 10:03am 22 April 2024 - ๐ฌ๐งUnited Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.