The toolbar workspace switcher is not redirecting to the current page

Darren Oh → made their first commit to this issue’s fork.

I'm not seeing any change in behavior with the Workspaces Extra module enabled. Merge request is ready for review.

The changes seem fine as mentioned in the proposed resolution. The workspace switcher is now redirecting to the current page.

Attached after screen recording.

Thanks

Hi
Tested MR !6605 on Drupal version 11.x
Applied MR Successfully...

Testing steps:
Install the workspaces module
Login as admin
Click on the "Configuration" link in the admin toolbar
Click the "Live" link in the top right of the toolbar to open the default workspace switcher
Click the "Stage" link and confirm the switch in the modal that opens
Apply the Patch and check for the same

Test Result:
The changes look as mentioned in the proposed resolution.
The workspace switcher is redirecting to the same page.

Attaching videos for references
RTBC++

Keeping in "Need review" for more reviews

Thanks for reporting. Will need a failing test as a next step.

Adding the url.path cache context to every page would be a performance regression, and we can avoid it if we use a lazy builder instead for the workspace toolbar tab, just like announcements_feed module does it.

I wasted a lot of time trying to add test coverage, with no success: https://git.drupalcode.org/project/drupal/-/merge_requests/7605/commits . Adding coverage for this should be as easy as adding a few more drupalGet() calls in WorkspaceToolbarIntegrationTest::testWorkspaceSwitch(), but our functional javascript test framework disagrees :/

My proposal is to go with only manual testing here, otherwise the issue will be stalled for who knows how many years...

Couple of questions on the MR.

Fixed both review points :)

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.