- Issue created by @dabodia
- Assigned to Vinayak.Ambig
- Issue was unassigned.
- 🇮🇳India Vinayak.Ambig
I have fixed the spacing issue and created patch. Attached screenshot for reference.
Also found one more issue modal box close icon alignment issue. Added fixes in this patch.
- Status changed to Needs review
over 1 year ago 11:02am 29 March 2023 - 🇪🇸Spain dabodia Valencia
Thanks for the patches but I'd say patching the
media_library
module shouldn't be the proper approach, as the module itself doesn't have the issue with different admin themes like Seven or Claro.Either way thanks for adding the RTL fix too, that was a really good spot.
- Status changed to Needs work
over 1 year ago 9:02pm 8 May 2023 - Assigned to Vinayak.Ambig
- Issue was unassigned.
- 🇮🇳India Vinayak.Ambig
dabodia I have verified your comment. As you mentioned above i'm not using from media_library module. Instead i'm using web/themes/contrib/gin/styles/components/media_library.scss.
- last update
over 1 year ago 6 pass - Status changed to Needs review
over 1 year ago 6:55am 30 June 2023 - 🇮🇳India Nitin shrivastava
@Vinayak.Ambig, I checked the patch mentioned in #5, and it appears it hasn't been applied. I verified this on both Drupal 10 and Drupal 9.
- Status changed to Needs work
10 months ago 9:34am 22 January 2024 - Status changed to Needs review
10 months ago 11:05am 22 January 2024 Can you share screenshots where you are getting spacing issues? I tested on Drupal 10 and I did not find anything misaligned.
- Status changed to Needs work
10 months ago 11:06am 22 January 2024 - First commit to issue fork.
- Status changed to Needs review
10 months ago 12:21pm 24 January 2024 - 🇮🇳India rupeshghar
It appears that the problem has already been addressed. I attempted to reproduce the issue, but I discovered that the required CSS code has already been implemented.
.media-library-wrapper { margin-top: 0; margin-left: calc(var(--gin-spacing-m) * -1); margin-right: calc(var(--gin-spacing-m) * -1); }<code>
- 🇮🇳India Kanchan Bhogade
Hi,
I have tested on the Drupal 10. 2 and Drupal 9.5 versions.Testing steps:
Install Drupal version
Install the Gin theme and gin toolbar
Install media and Media Library core module
Add a Midea field for any content type with multiple options
Create a page for content type, and add media
Check for the Add media modalTest Result:
The cross icon is aligned correctly, but the 'Apply Filter' button at the bottom is slightly misaligned for Drupal 10.2 and for Drupal 9.5 all looks goodAttaching screenshots for reference.
- 🇩🇪Germany yannickoo Berlin
Hey 👋 I've just tried to reproduce this issue but I cannot see any weird alignments here. Nothing visually bad with the close icon of the modal nor the "Apply filters" button.
The only wrong thing I can see here are the vertical tabs that you can see when having multiple media bundles enabled for referencing.
- 🇮🇳India ehsann_95
I also tried to reproduce the issue with given steps. I was not able to find any spacing or alignment issues and everything looked good to me.
- 🇨🇳China marcolam
I just upgraded drupal core from 10.1 to 10.2,and the media library browser displayed not correctly like #20, the media type filter style lost.
- Status changed to Needs work
9 months ago 11:00am 12 February 2024 - Status changed to Needs review
9 months ago 3:56pm 14 February 2024 - 🇩🇪Germany yannickoo Berlin
@shweta__sharma please create a new issues for that, this this issue for something else.
- 🇫🇷France duaelfr Montpellier, France
For people having issues after upgrading to Drupal 10.2 with vertical tabs having lost their styles: 🐛 [Drupal 10.2 regression] Media Library "widget" View media type tabs have lost styling RTBC
- Status changed to Closed: cannot reproduce
5 months ago 12:50pm 3 July 2024