🇪🇸Spain @dabodia

Valencia
Account created on 6 July 2021, over 3 years ago
  • Front-end Developer at Zoocha 
#

Recent comments

🇪🇸Spain dabodia Valencia

I've checked the changes myself and they're looking good, though I agree with andyf on:

I think that's perhaps a strong use of break: it will switch off a feature to prevent orphans IIUC, which is arguably less of a break than adding extra markup without warning and the associated visual regressions.

I've already had this become an issue on 3 sites and it would be ideal to have it default as FALSE but I would be happy anyway if we had the setting to switch on/off and it defaulted to TRUE

🇪🇸Spain dabodia Valencia

Same as previous comments, +1 for MR!459. It works well in all possible dropdown positions

🇪🇸Spain dabodia Valencia

Thanks for the patches but I'd say patching the media_library module shouldn't be the proper approach, as the module itself doesn't have the issue with different admin themes like Seven or Claro.

Either way thanks for adding the RTL fix too, that was a really good spot.

Production build 0.71.5 2024