[Drupal 10.2 regression] Media Library "widget" View media type tabs have lost styling

Sandeep Sanwale → made their first commit to this issue’s fork.

In claro theme the base folder contains variable.pcss.css file which have root variables for other css files where variables for verticle tabs were missing which i have add it through this patch .

The patch applies to 10.2.2 and restores the proper styling.

The target branch should be set back to 11.x. Committers will backport to 10.2 if possible.

Also, some questions were raised in 🐛 Media Type links in Media Library modal missing vertical tabs styling in Claro RTBC which turned out to be a duplicate of this issue:
#50 🐛 Media Type links in Media Library modal missing vertical tabs styling in Claro RTBC

I'm quite sure a subsystem maintainer will request the same - no point loading those variables on every page, those are component variables, be it vertical tabs or media library media type links. Those variables should be included conditionally, only if one or both components are present in the current context.

The bug was introduced trying to follow the pattern to moving the variables to its own component without knowing they would be needed by another one (Media Library). And with this changes we're getting back to the point were variables that belong to a component are on base.
The ideal solution would the one were the 2 components are really the same, but that's not doable. The second ideal solution would be to make these variables name generic enough to be used in two different components, but I'm afraid it might lead to some bikeshedding in the issue (naming tends to bring that).
So I'd focus on preventing it happens again apart from fixing the bug. I would recommend to to add a comment on the variables block that explains those variables are needed in 2 places, both Vertical Tabs and Media Library.

Added commit to MR with comment per #8 🐛 [Drupal 10.2 regression] Media Library "widget" View media type tabs have lost styling RTBC and removed properties from vertical tabs files.

Pinged in slack for a MR target change to 11.x

godotislate → changed the visibility of the branch 10.2.x to hidden.

godotislate → changed the visibility of the branch 11.x to hidden.

Hi all,

Steps to reproduce for the issue.
1. Drupal Version 11.x
2. Administration theme Claro
3. Add a media field to a content type.
4. Add two or more media types as reference type for the added media field.
5. Create a node for that content type
6. Attempt to attach a media item to the field.
7. Applied MR !6327

Result:
Before MR

After MR

RTBC ++

I can confirm that the proposed patch/MR fixes the issue.
I agree with @ckrina that this is not the ideal solution, though. I wonder if it wouldn't be better to create a new library for vertical-tabs styling and make both vertical tabs and media library libraries depend on it. Any thoughts, boss? :)

lauriii → closed merge request !6327

Looks like the bug is fixed and #8 has been addressed. Would be nice for sure to have a common component between these two use cases but it doesn't have to happen here.

Committed 89fde7a and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

This issue was released in Drupal 10.2.4, see https://www.drupal.org/project/drupal/releases/10.2.4 →