Improper position of the progress throbber.

Created on 10 August 2023, over 1 year ago
Updated 2 August 2024, 4 months ago

Problem/Motivation

The position of the progress throbber on the admin/structure/views is not correct.

Steps to reproduce

1)Navigate to admin/structure/views.
2) Click on Drop down and click say for example delete.
3)Close the dropdown.
The position of the throbber is below the edit button.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
Claroย  โ†’

Last updated 1 day ago

Created by

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

  • Issue created by @utkarsh_33
  • Status changed to Needs review over 1 year ago
  • last update over 1 year ago
    29,958 pass
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia gauravvvv Delhi, India

    I have attached a patch for same, also added after patch screenshot for same. please review

    After Patch

  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland lauriii Finland
    1. +++ b/core/themes/claro/css/theme/views_ui.admin.theme.pcss.css
      @@ -640,6 +640,11 @@ td.group-title {
       .views-list-section {
      ...
      +  & .ajax-progress--throbber {
      

      This problem isn't specific to the views list, this bug could happen on any table that uses operations with ajax. The reason this is more prone to happen on the views list table is that it has a lot of columns and long description texts, making the operations column less likely to have additional space for the throbber.

    2. +++ b/core/themes/claro/css/theme/views_ui.admin.theme.pcss.css
      @@ -640,6 +640,11 @@ td.group-title {
      +    position: absolute;
      +    margin-block-start: 5px;
      

      It might be acceptable to use position: absolute but there might be better approaches. The key drawback with this approach is that when there isn't a lot of space (like on a narrow screen), the throbber might be pushed outside of the table.

  • Status changed to Needs review about 1 year ago
  • last update about 1 year ago
    Custom Commands Failed
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia swatidhurandhar

    This issue is due to a lack of space in the table columns; if the operations column width is not enough, then the progress throbber moves to the next line. I have checked other tables, like on the content page, where throbber comes next to operation links since there is enough space.

    All the columns in the views page table have a width defined, which is added in the views UI module. So I changed the width of two columns in theme to provide enough space for the throbber icon, which then moved to the right side of the operations button.

  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    CC failure in #4

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia gauravvvv Delhi, India

    In patch #4, I think we should not fix the width of table columns.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia swatidhurandhar

    The ajax throbber has global styling which is working for all the tables. The reason for throbber coming to next line was due to the space issue that's why reduced the width of column in views table.

  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Environment: PHP 8.1 & MariaDB 10.3.22
    last update 12 months ago
    30,604 pass
  • Assigned to rupeshghar
  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia akashdab

    As highlighted by many before, there is a lack of space after the Edit dropdown to accommodate the throbber inline.
    As it stays right now, the entire Edit dropdown field is 128px in width, of which 96px is the width of the dropdown element, 32 px is the width shared onto either sides of the dropdown.
    To successfully include the throbber inline there needs to be at least 42px space after the dropdown, as that is the width the throbber takes.

    To tackle this there are 3 approaches we can take,

    1. Involves redistributing the width taken by the table header.
    2. Involves redistributing the width taken by the table header, and
        2(a). reducing padding of the Edit dropdown element.
        2(b). reducing padding of the Edit dropdown element and reducing margin taken by ajax throbber.


    1. Redistributing the width taken by the table header.

    1. Reduce the width of View name table header from 20% to 15%.
    2. In turn allocate the free space to Operations table header, increasing it from 10% to 15%.
    3. Doing this increases the width of Edit dropdown from 96px to approximately 145px, consequently making enough space for the throbber.
        Method 1 Plain View
        Method 1 Calculated


    2(a). Redistributing the width from the table header and reducing padding of edit dropdown.

    1. This one takes ideas from patch-4, reducing the width of View name table header from 20% to 17%.
    2. Allocating the free space to Operations TH, increasing its width from 10% to 13%.
    3. Reducing the padding from TD of Operations TH, from 16px to 7px (or .45 rem ~ 7px)
        Method 2(a) Plain View
        Method 2(a) Calculated


    2(b). Redistributing the width from the table header, reducing padding of edit dropdown and reducing margin taken by ajax throbber.

    1. Reducing the width of View name table header from 20% to 17%.
    2. Allocating the free space to Operations TH, increasing its width from 10% to 13%.
    3. Reducing the padding from TD of Operations TH, from 16px to 10px (or .625rem)
    4. Reducing the margin from ajax throbber from 12px to 9px (0.5625rem).

        Method 2(b) Plain View

        Method 2(b) Calculated

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia hetal.solanki

    Hetal.Solanki โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024