- Issue created by @mrshowerman
- Merge request !386Preserve bottom margin on text fields in paragraphs → (Merged) created by mrshowerman
- Issue was unassigned.
- Status changed to Needs review
11 months ago 4:59pm 8 February 2024 - Status changed to Needs work
11 months ago 5:37pm 8 February 2024 - 🇮🇳India djsagar
@mrshowerman not able to replicate issue Drupal version 10.2.2 with gin theme.
Please share STR to replicate.
Updating tags moving NW.
- Status changed to Needs review
11 months ago 10:24am 9 February 2024 - 🇮🇳India divya.sejekan
I tried replicating but im stuck at 'Hide the help link About text formats' , Unable to find the hide option . Im using drupal 10.17x .
- 🇩🇪Germany mrshowerman Munich
@divya.sejekan, did you install and activate the module "Hide Format info (former Allowed Formats)"?
- 🇮🇳India djsagar
@mrshowerman please explain, how to hide text formats in text editor.
- 🇮🇳India divya.sejekan
@mrshowerman . Added hide format info as you said . But i couldn't replicate the issue. There is spacing and looks fine
Testing steps followed :
1. Install Paragraph , hide format info
2. Add a paragraph in CT with limited to 1
3. For body field set the text format to 1 text format , and hide the about text format option in Manage form display settings.
4. Verify in CT node - 🇩🇪Germany mrshowerman Munich
@divya.sejekan, thanks for testing this issue.
It is about spacing between fields within a paragraph, not the spacing between the paragraph and other node fields.
I updated the steps to reproduce in the IS to make this clear. - 🇮🇳India Kanchan Bhogade
Hi
Verified and tested on Drupal version 10.1 for the Gin theme- Successfully able to reproduce the issue
Testing Steps
- Install drupal version
- Install the GIn theme and set it as the default
- Install modules Paragraphs and Hide Format info (former Allowed Formats)
- Add a formatted with summary text field to a paragraph and select only one text format (e.g., Basic HTML)
- Add another field to the same paragraph, e.g. a link field.
- In the entity form, activate the options Hide the help link About text formats. and Hide text format guidelines. Specify the field order such that the link field is below the text field.
- Edit a node of a type that uses the paragraph.
Result: no spacing between the text and the link field. (screenshot)
- Issue Summary Screenshot:
Creating confusion, it looks like two different paragraphs have spacing issue;
I checked for two paragraphs and the spacing between them looks good (screenshot)- Tested for MR !386 on Drupal 10.1 for gin theme
MR Applied Successfully...
Test Result:
The padding issue with text fields in paragraph is not fixed; spacing is not added.Attaching screenshot for reference
keeping in to "Needs review" for code review and more reviews
Verified and tested on Drupal version 10.2 for the Gin theme
Successfully able to reproduce the issue
Testing StepsInstall drupal version
Install the GIn theme and set it as the default
Install modules Paragraphs and Hide Format info (former Allowed Formats)
Add a formatted with summary text field to a paragraph and select only one text format (e.g., Basic HTML)
Add another field to the same paragraph, e.g. a link field.
In the entity form, activate the options Hide the help link About text formats. and Hide text format guidelines. Specify the field order such that the link field is below the text field.
Edit a node of a type that uses the paragraph.
Result: no spacing between the text and the link field. (screenshot)Tested for MR !386 on Drupal 10.2 for gin theme
MR Applied Successfully...Test Result:
The padding issue with text fields in paragraph is not fixed; spacing is not added.Attaching screenshot for reference
keeping in to "Needs review" for code review and more reviews
- Status changed to Needs work
10 months ago 7:40am 14 February 2024 As per #11 and #12 testing the issue is not resolved with the patch so moving to need work.
- Status changed to Needs review
10 months ago 10:21am 14 February 2024 - Assigned to Kanchan Bhogade
- Issue was unassigned.
- 🇮🇳India Kanchan Bhogade
Hi
Verified and tested MR !386 on Drupal version 10.1 for the Gin theme
Applied patch Successfully...Test Result:
The padding issue with text fields in paragraph is fixed; After text field spacing is addedAttaching screenshot for reference
keeping into "Needs review" for code review
- Status changed to Needs work
10 months ago 12:14pm 14 February 2024 - Status changed to Needs review
10 months ago 3:37pm 20 February 2024 - Status changed to RTBC
10 months ago 10:04am 21 February 2024 - 🇮🇳India Kanchan Bhogade
Hi,
tested for updated MR !386 on Drupal 10.1
The patch was applied successfully...Result:
After text field spacing is visible with updated Merge Request.Attaching Screenshot
RTBC+1
Tested Merge request! 386 on the latest version of Drupal. The space is added at the bottom of the field now.
RTBC+!
- Status changed to Fixed
9 months ago 1:19pm 28 March 2024 - 🇺🇸United States capellic Austin, Texas
I was looking for a solution to this and found this ticket. Time for an upgrade! Thanks all!!
Automatically closed - issue fixed for 2 weeks with no activity.