Linked in instagram icons are not visible in footer

Created on 19 February 2024, 4 months ago
Updated 28 May 2024, 27 days ago

Problem/Motivation

Linked-in Instagram icons are not visible in the footer. The code is present but icons and href links are not added. See the attached screenshot for reference.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @shweta__sharma
  • First commit to issue fork.
  • 🇮🇳India ravi kant Jaipur

    Needs to provide configuration in theme setting.

  • Assigned to sourojeetpaul
  • Hello, @ravi kant
    Your suggestion is absolutely valid and more user friendly, but I'm afraid that it is beyond the scope of this issue. So it'll be better if we stick to the scope of the issue and try to target it as per the issue summary. Feel free to raise another issue, which can be labelled as a feature request as well and I will try to address that as well.

    So for the time being, I'm addressing the issue staying in the scope of the issue summary!

  • Merge request !11Issue #3422319 : Icon visibility fix. → (Open) created by sourojeetpaul
  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • Hi, @shweta__sharma, The issue has now been resolved. Raised an MR for the same please have a look:
    https://git.drupalcode.org/project/moksu/-/merge_requests/11

    This is how the footer icons are appearing now:

  • Hi, reviewed the MR 11, Applied cleanly and adds instagram, youtube, linkedin icons.

  • Hi, @bindu r, as you already tested this and works fine for you, can you kindly change the status to RTBC to help the ticket move forward!
    I see its still in NR state!

  • Status changed to Needs work 2 months ago
  • 🇮🇳India Kanchan Bhogade

    Hi
    I've tested MR !11 on Drupal version 10
    MR applied Cleanly but links were not added

    Adding a screenshot for the reference

    Moving to needs work

  • First commit to issue fork.
  • Merge request !15Resolve #3422319 "Social icons" → (Open) created by adarshv
  • Status changed to Needs review 2 months ago
  • 🇮🇳India adarshv

    The issue has been resolved now. Additionally, I have added a setting to update the social icon URL in the theme settings.
    Please check MR !15 above.

  • 🇮🇳India Kanchan Bhogade

    Hi
    I've tested MR !15 on Drupal version 10
    The MR is applied successfully...

    LinkedIn and Instagram icons are added in the footer and for Social icons URL setting is available in the Themes Settings.

    adding screenshots for references

    Keeping in "Needs Review" for More reviews around Both the MRs and which approach is better.

  • Status changed to RTBC 27 days ago
  • 🇮🇳India Vivek Panicker Kolkata

    As @Kanchan Bhogade has already tested the patch and things are looking fine, moving the issue to RTBC state.

Production build 0.69.0 2024