- Issue created by @Grimreaper
- 🇫🇷France Grimreaper France 🇫🇷
Note: not having the dev branch 8.x-2.x-dev published is not helping for the fork/MR workflow to work simply.
- 🇫🇷France Grimreaper France 🇫🇷
Note 2: Ok, I just realize now that the 8.x-2.x branch does not exist at all in the main repository.
- @grimreaper opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:30pm 13 April 2023 - 🇫🇷France Grimreaper France 🇫🇷
- Status changed to RTBC
4 months ago 7:16am 13 September 2024 Hello,
I've installed the module version 3.0.0 in Drupal 10.3.4 and added icons in the main navigation menu links followed by configuring the appearance to without text. Found the aria-label is being set in the<li>
hence when the screen reader reads the menu link, it fails to identify the aria-label. After applying the MR!2, the aria-label is set in the<a>
which is identified by the screen reader correctly. The issue is raised for 8.x-2.0, but it still persists in 3.0.0 and the provided MR applies in the latest version cleanly therefore need to port the changes in 3.x-dev. The MR resolves the issue therefore moving to RTBC, including before and after ss.
Thanks